All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Len Brown <lenb@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Pavel Machek <pavel@suse.cz>,
	Cheng Renquan <crquan@gmail.com>,
	pm list <linux-pm@lists.linux-foundation.org>,
	Ingo Molnar <mingo@elte.hu>,
	Masami Hiramatsu <mhiramat@redhat.com>
Subject: [PATCH 2/2] kprobes: check CONFIG_FREEZER instead of CONFIG_PM
Date: Tue, 6 Jan 2009 21:15:32 +0100	[thread overview]
Message-ID: <200901062115.33286.rjw__11067.8286677741$1231273218$gmane$org@sisk.pl> (raw)
In-Reply-To: <200901062112.29227.rjw@sisk.pl>

From: Masami Hiramatsu <mhiramat@redhat.com>

Check CONFIG_FREEZER instead of CONFIG_PM because kprobe booster
depends on freeze_processes() and thaw_processes() when CONFIG_PREEMPT=y.

This fixes a linkage error which occurs when CONFIG_PREEMPT=y, CONFIG_PM=y
and CONFIG_FREEZER=n.

Reported-by: Cheng Renquan <crquan@gmail.com>
Signed-off-by: Masami Hiramatsu <mhiramat@redhat.com>
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
 arch/ia64/kernel/kprobes.c |    2 +-
 arch/x86/kernel/kprobes.c  |    2 +-
 kernel/kprobes.c           |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/arch/ia64/kernel/kprobes.c
===================================================================
--- linux-2.6.orig/arch/ia64/kernel/kprobes.c
+++ linux-2.6/arch/ia64/kernel/kprobes.c
@@ -868,7 +868,7 @@ static int __kprobes pre_kprobes_handler
 		return 1;
 
 ss_probe:
-#if !defined(CONFIG_PREEMPT) || defined(CONFIG_PM)
+#if !defined(CONFIG_PREEMPT) || defined(CONFIG_FREEZER)
 	if (p->ainsn.inst_flag == INST_FLAG_BOOSTABLE && !p->post_handler) {
 		/* Boost up -- we can execute copied instructions directly */
 		ia64_psr(regs)->ri = p->ainsn.slot;
Index: linux-2.6/arch/x86/kernel/kprobes.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/kprobes.c
+++ linux-2.6/arch/x86/kernel/kprobes.c
@@ -445,7 +445,7 @@ void __kprobes arch_prepare_kretprobe(st
 static void __kprobes setup_singlestep(struct kprobe *p, struct pt_regs *regs,
 				       struct kprobe_ctlblk *kcb)
 {
-#if !defined(CONFIG_PREEMPT) || defined(CONFIG_PM)
+#if !defined(CONFIG_PREEMPT) || defined(CONFIG_FREEZER)
 	if (p->ainsn.boostable == 1 && !p->post_handler) {
 		/* Boost up -- we can execute copied instructions directly */
 		reset_current_kprobe();
Index: linux-2.6/kernel/kprobes.c
===================================================================
--- linux-2.6.orig/kernel/kprobes.c
+++ linux-2.6/kernel/kprobes.c
@@ -122,7 +122,7 @@ static int collect_garbage_slots(void);
 static int __kprobes check_safety(void)
 {
 	int ret = 0;
-#if defined(CONFIG_PREEMPT) && defined(CONFIG_PM)
+#if defined(CONFIG_PREEMPT) && defined(CONFIG_FREEZER)
 	ret = freeze_processes();
 	if (ret == 0) {
 		struct task_struct *p, *q;

      parent reply	other threads:[~2009-01-06 20:15 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-06 20:12 [PATCH 0/2] PM: Compilation fixes related to the freezer Rafael J. Wysocki
2009-01-06 20:14 ` [PATCH 1/2] PM: Fix freezer compilation if PM_SLEEP is unset Rafael J. Wysocki
2009-01-06 20:14 ` Rafael J. Wysocki
2009-01-06 20:15 ` [PATCH 2/2] kprobes: check CONFIG_FREEZER instead of CONFIG_PM Rafael J. Wysocki
2009-01-07 12:16   ` Ingo Molnar
2009-01-07 12:16     ` Ingo Molnar
2009-01-09 20:30     ` Len Brown
2009-01-09 20:30     ` Len Brown
2009-01-11  3:49       ` Ingo Molnar
2009-01-11  3:49       ` Ingo Molnar
2009-02-10  1:05       ` Ingo Molnar
2009-02-10  1:05       ` Ingo Molnar
2009-02-09 20:51         ` Masami Hiramatsu
2009-02-10 12:37           ` Ingo Molnar
2009-02-10 12:37           ` Ingo Molnar
2009-02-10 13:56             ` Rafael J. Wysocki
2009-02-10 13:56             ` Rafael J. Wysocki
2009-02-10 15:54               ` Masami Hiramatsu
2009-02-10 15:54               ` Masami Hiramatsu
2009-02-10 21:40                 ` Rafael J. Wysocki
2009-02-10 21:40                 ` Rafael J. Wysocki
2009-02-11  1:23                   ` Masami Hiramatsu
2009-02-11  1:23                   ` Masami Hiramatsu
2009-02-11  9:38                     ` Rafael J. Wysocki
2009-02-11 21:33                       ` [PATCH] PM: Fix build for CONFIG_PM unset Rafael J. Wysocki
2009-02-08 23:47                         ` Pavel Machek
2009-02-08 23:47                         ` Pavel Machek
2009-02-11 21:33                       ` Rafael J. Wysocki
2009-02-11  9:38                     ` [PATCH 2/2] kprobes: check CONFIG_FREEZER instead of CONFIG_PM Rafael J. Wysocki
2009-02-09 20:51         ` Masami Hiramatsu
2009-01-06 20:15 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='200901062115.33286.rjw__11067.8286677741$1231273218$gmane$org@sisk.pl' \
    --to=rjw@sisk.pl \
    --cc=crquan@gmail.com \
    --cc=lenb@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@lists.linux-foundation.org \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=pavel@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.