From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1LMGgJ-0004Jp-OJ for qemu-devel@nongnu.org; Mon, 12 Jan 2009 01:53:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1LMGgH-0004H4-Qq for qemu-devel@nongnu.org; Mon, 12 Jan 2009 01:53:50 -0500 Received: from [199.232.76.173] (port=55888 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1LMGgH-0004Gp-Cw for qemu-devel@nongnu.org; Mon, 12 Jan 2009 01:53:49 -0500 Received: from 2.mail-out.ovh.net ([91.121.26.226]:36554) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1LMGgG-00040Z-Qi for qemu-devel@nongnu.org; Mon, 12 Jan 2009 01:53:49 -0500 Date: Mon, 12 Jan 2009 07:42:27 +0100 From: Jean-Christophe PLAGNIOL-VILLARD Subject: Re: [Qemu-devel] [PATCH 3/3] sh: SCI improvements Message-ID: <20090112064227.GB26923@game.jcrosoft.org> References: <4969B880.10600@juno.dti.ne.jp> <4969B8F0.4020104@juno.dti.ne.jp> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4969B8F0.4020104@juno.dti.ne.jp> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Shin-ichiro KAWASAKI Cc: qemu-devel@nongnu.org On 18:16 Sun 11 Jan , Shin-ichiro KAWASAKI wrote: > SE7750 uses SCI := Serial Communication Interface for one of consoles. > This patch completes the SCI implementation, and makes SCI available > for a console. > > # Tabs and spaces are mixed in "hw/sh_serial.c" so much. > # Some clean up might be useful. > > > Signed-off-by: Shin-ichiro KAWASAKI > (I'm working on it and have result to nearly the same patch) I've test your code against current U-Boot and I've found that the input stell no working after some debug I've that qemu call twice the function sh_serial_can_receive1 which return false twice. Just after U-Boot enable the receive (writing RE and TE in SCR) but qemu will not re-call sh_serial_can_receive1. As test If we force to always return 1 to sh_serial_can_receive1 the input work I've start to search how to notify qemu that U-Boot active/desativate the receive Best Regards, J.