From: "Boyd Stephen Smith Jr." <bss@iguanasuicide.net>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Ted Pavlic <ted@tedpavlic.com>, git <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u."
Date: Tue, 13 Jan 2009 14:03:11 -0600 [thread overview]
Message-ID: <200901131403.16012.bss@iguanasuicide.net> (raw)
In-Reply-To: <20090113164518.GS10179@spearce.org>
[-- Attachment #1: Type: text/plain, Size: 1076 bytes --]
On Tuesday 2009 January 13 10:45:18 Shawn O. Pearce wrote:
>See [...] how the subject is a niceshort, one
>line summary of the module impacted and the change?
My rule for this is absolutely no more than 80 characters. Generally, you
wouldn't want more than 60 or so, since it is used as the Subject: header and
generally has some prefix added.
As shown says, details can go in the rest of the commit message. If you are
using more than 60-80 characters even without details, you might think about
splitting the patch.
>This is all based on the formatting at the time of commit.
>Anything up to the first "\n\n" in a commit message goes into the
>email subject line.
IIRC, multiple "-m" options to "git commit" will be separated by "\n\n", so
that's one way to do it if you don't like your $EDITOR for some reason.
--
Boyd Stephen Smith Jr. ,= ,-_-. =.
bss@iguanasuicide.net ((_/)o o(\_))
ICQ: 514984 YM/AIM: DaTwinkDaddy `-'(. .)`-'
http://iguanasuicide.net/ \_/
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-01-13 20:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-13 16:11 [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u." Ted Pavlic
2009-01-13 16:45 ` Shawn O. Pearce
2009-01-13 20:03 ` Boyd Stephen Smith Jr. [this message]
2009-01-13 20:10 ` Adeodato Simó
2009-01-13 20:24 ` Commit messages Teemu Likonen
2009-01-14 16:55 ` Ted Pavlic
2009-01-15 22:56 ` [PATCH 3/3] Adds a #!bash to the top of bash completions so that editors can recognize, it as a bash script. Also adds a few simple comments above commands that, take arguments. The comments are meant to remind editors of potential, problems that can occur when the script is sourced on systems with "set, -u." Markus Heidelberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200901131403.16012.bss@iguanasuicide.net \
--to=bss@iguanasuicide.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
--cc=ted@tedpavlic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.