From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Rafael J. Wysocki" Subject: Re: [PATCH 05/13] PM: Add option to disable /sys/power/state interface Date: Sun, 8 Feb 2009 14:50:45 +0100 Message-ID: <200902081450.46584.rjw@sisk.pl> References: <1233802226-23386-1-git-send-email-arve@android.com> <200902072337.40046.rjw@sisk.pl> <20090208103355.GC14143@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090208103355.GC14143@elf.ucw.cz> Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Pavel Machek Cc: ncunningham@crca.org.au, u.luckas@road.de, swetland@google.com, linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Sunday 08 February 2009, Pavel Machek wrote: > On Sat 2009-02-07 23:37:39, Rafael J. Wysocki wrote: > > On Thursday 05 February 2009, Arve Hj??nnev??g wrote: > > > Signed-off-by: Arve Hj??nnev??g > > > > This is completely wrong, IMO. > > > > Removing an interface that has existed forever just because it happens to > > be incompatible with your new shiny feature is not acceptable to me. > > Agreed. AFAICS this patch can be just dropped, or maybe kept specially > for android if those few bytes matter to them. Just to make things crystal clear, in fact I don't like any patches in this series. The wakelocks seem to be overdesigned to me and the "early suspend" thing doesn't really fit our suspend-resume framework, especially after the changes made recently to the PCI PM code (and the changes that are going to be made to it shortly). Thanks, Rafael