From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pavel Machek Subject: Re: [PATCH 05/13] PM: Add option to disable /sys/power/state interface Date: Mon, 9 Feb 2009 00:03:35 +0100 Message-ID: <20090208230335.GU6369@elf.ucw.cz> References: <20090208210401.GE6369@elf.ucw.cz> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-pm-bounces@lists.linux-foundation.org Errors-To: linux-pm-bounces@lists.linux-foundation.org To: Arve Hj?nnev?g Cc: ncunningham@crca.org.au, u.luckas@road.de, swetland@google.com, linux-pm@lists.linux-foundation.org List-Id: linux-pm@vger.kernel.org On Sun 2009-02-08 15:00:38, Arve Hj?nnev?g wrote: > On Sun, Feb 8, 2009 at 1:40 PM, Alan Stern wrote: > > On Sun, 8 Feb 2009, Pavel Machek wrote: > > > >> Well, it is true that wakelocks could be single atomic_t ... but they > >> would make them undebuggable. Ok, wakelock interface sucks. But I > >> believe something like that is neccessary. > > > > krefs don't have name strings for keeping track of who has been > > incrementing or decrementing their counters. And it's true that krefs > > are nearly undebuggable. But somehow we've managed to struggle along > > without adding names to krefs. Why should wakelocks be any different? > > It sounds like you suggesting that we add another nearly undebuggable interface. > > Using only a single atomic_t would not allow us to use a wakelock a > switch, or to specify a timeout. You could replace the list in the > implementation with a single atomic_t by adding more state to each > wakelock, but I like my current solution better. For the record, I agree here. And... if struct wakelock contains char * or not is a very small detail. If wakelocks can be locked from userspace is _not_ a detail; and if they can we do need the names. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html