All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Paul Menage <menage@google.com>
Cc: miaox@cn.fujitsu.com, Andrew Morton <akpm@linux-foundation.org>,
	mingo@elte.hu, linux-kernel@vger.kernel.org,
	cl@linux-foundation.org
Subject: Re: [PATCH] cpuset: fix allocating page cache/slab object on the unallowed node when memory spread is set
Date: Mon, 9 Feb 2009 15:02:25 +1100	[thread overview]
Message-ID: <200902091502.27056.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <6599ad830902061119t2d82c782pb6442f9a35fbb01c@mail.gmail.com>

On Saturday 07 February 2009 06:19:27 Paul Menage wrote:
> On Wed, Feb 4, 2009 at 1:31 AM, Miao Xie <miaox@cn.fujitsu.com> wrote:
> >> AFAICS this patch still has a race between a thread reading its
> >> mems_allowed, and another thread updating it. The current architecture
> >> of having task->mems_allowed be only updatable by current was PaulJ's
> >> code originally, and I'm a bit loathe to touch it. But if we're going
> >> to, we'll need at the minimum to add a lock for any code that touches
> >> current->mems_allowed.
> >
> > Agree! But mems_allowed is touched in the module of memory management
> > in general, adding a lock to protect mems_allowed may lead to performance
> > regression.
>
> I've asked Andrew to remove this from -mm until we can figure out:
>
> - whether it's needed
> - how to do it safely.

Is it a problem if mems_allowed can get sampled in an unsafe way?
It will happen only quite rarely. This code seems to be far simpler
and more robust than the current fragile scheme, so it would be
nice to use it.


  reply	other threads:[~2009-02-09  4:03 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-21  8:06 [PATCH] cpuset: fix allocating page cache/slab object on the unallowed node when memory spread is set Miao Xie
2009-01-21  8:30 ` Nick Piggin
2009-01-21 10:41 ` Paul Menage
2009-02-03  3:05   ` Miao Xie
2009-01-27 22:42 ` Andrew Morton
2009-01-28 16:38   ` Christoph Lameter
2009-02-03  3:25   ` Miao Xie
2009-02-03 22:16     ` Andrew Morton
2009-02-03 22:49       ` Paul Menage
2009-02-04  9:31         ` Miao Xie
2009-02-06 19:19           ` Paul Menage
2009-02-09  4:02             ` Nick Piggin [this message]
2009-02-10 11:37               ` Paul Menage
2009-02-12  0:54                 ` Nick Piggin
2009-02-12  1:19                   ` Paul Menage
2009-02-12  1:55                     ` Nick Piggin
2009-02-12  1:58                       ` Paul Menage
2009-02-12  8:23                       ` Miao Xie
2009-02-12 21:53                         ` Paul Menage
2009-02-12  8:27                       ` Miao Xie
2009-02-12 10:40                         ` Nick Piggin
2009-02-12  5:57                     ` Miao Xie
2009-02-12 11:06                       ` Paul Jackson
2009-02-04  9:03       ` Miao Xie

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200902091502.27056.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=cl@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=menage@google.com \
    --cc=miaox@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.