All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Kara <jack@suse.cz>
To: Theodore Tso <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org,
	Andrew Morton <akpm@linux-foundation.org>,
	mfasheh@suse.com
Subject: Re: [PATCH 0/3] Fix possible NULL pointer dereference in JBD2
Date: Mon, 9 Feb 2009 18:34:41 +0100	[thread overview]
Message-ID: <20090209173441.GA3824@duck.suse.cz> (raw)
In-Reply-To: <20090205213744.GA9814@mit.edu>

On Thu 05-02-09 16:37:44, Theodore Tso wrote:
> On Thu, Feb 05, 2009 at 03:52:59PM +0100, Jan Kara wrote:
> > 
> 
> >   the three patches below fix a bug in
> > jbd2_journal_begin_ordered_truncate() that could possibly lead to
> > NULL pointer dereference. The question is how to merge the fix as it
> > changes the prototype of the function and both ext4 and ocfs2 use
> > it.  Mark, Mingming, any suggestions?
> 
> Jan, how how easy is it to hit this?  Do you believe we should try to
> get this in for 2.6.29?  I got some final things to push to Linus so
> I can also push it via the ext4 tree.  I doubt it will conflict with
> > anything in my tree, either.
  The possibility of hitting this is quite small. We check
inode->i_transaction for NULL just before dereferencing it so the commit
would have to set it to NULL just between those two instructions.

								Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR

      reply	other threads:[~2009-02-09 17:34 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-05 14:52 [PATCH 0/3] Fix possible NULL pointer dereference in JBD2 Jan Kara
2009-02-05 14:53 ` [PATCH 1/3] jbd2: Fix possible NULL pointer dereference in jbd2_journal_begin_ordered_truncate() Jan Kara
2009-02-05 14:53   ` [Ocfs2-devel] " Jan Kara
2009-02-05 14:53   ` [PATCH 2/3] ext4: Add journal parameter to jbd2_journal_begin_ordered_truncate() Jan Kara
2009-02-05 14:53     ` [PATCH 3/3] ocfs2: " Jan Kara
2009-02-05 14:53       ` [Ocfs2-devel] " Jan Kara
2009-02-10  3:19       ` Joel Becker
2009-02-10  3:19         ` Joel Becker
2009-02-10 15:12       ` Theodore Tso
2009-02-10 15:12         ` [Ocfs2-devel] " Theodore Tso
2009-02-11  9:25         ` Jan Kara
2009-02-11  9:25           ` [Ocfs2-devel] " Jan Kara
2009-02-11 21:01         ` Mark Fasheh
2009-02-11 21:01           ` [Ocfs2-devel] " Mark Fasheh
2009-02-05 19:32 ` [PATCH 0/3] Fix possible NULL pointer dereference in JBD2 Mark Fasheh
2009-02-05 21:37 ` Theodore Tso
2009-02-09 17:34   ` Jan Kara [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090209173441.GA3824@duck.suse.cz \
    --to=jack@suse.cz \
    --cc=akpm@linux-foundation.org \
    --cc=linux-ext4@vger.kernel.org \
    --cc=mfasheh@suse.com \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.