From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755344AbZBJN5Q (ORCPT ); Tue, 10 Feb 2009 08:57:16 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753949AbZBJN5A (ORCPT ); Tue, 10 Feb 2009 08:57:00 -0500 Received: from ogre.sisk.pl ([217.79.144.158]:48829 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753802AbZBJN5A (ORCPT ); Tue, 10 Feb 2009 08:57:00 -0500 From: "Rafael J. Wysocki" To: Ingo Molnar Subject: Re: [PATCH 2/2] kprobes: check CONFIG_FREEZER instead of CONFIG_PM Date: Tue, 10 Feb 2009 14:56:19 +0100 User-Agent: KMail/1.11.0 (Linux/2.6.29-rc2-tst; KDE/4.2.0; x86_64; ; ) Cc: Masami Hiramatsu , Len Brown , pm list , Pavel Machek , LKML , Cheng Renquan , Andrew Morton References: <200901062112.29227.rjw@sisk.pl> <49909764.3020303@redhat.com> <20090210123734.GB21531@elte.hu> In-Reply-To: <20090210123734.GB21531@elte.hu> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200902101456.20147.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tuesday 10 February 2009, Ingo Molnar wrote: > > * Masami Hiramatsu wrote: > > > Ingo Molnar wrote: > >> * Len Brown wrote: > >> > >>>>> Check CONFIG_FREEZER instead of CONFIG_PM because kprobe booster > >>>>> depends on freeze_processes() and thaw_processes() when CONFIG_PREEMPT=y. > >>>>> > >>>>> This fixes a linkage error which occurs when CONFIG_PREEMPT=y, CONFIG_PM=y > >>>>> and CONFIG_FREEZER=n. > >>>>> > >>>>> Reported-by: Cheng Renquan > >>>>> Signed-off-by: Masami Hiramatsu > >>>>> Signed-off-by: Rafael J. Wysocki > >>>>> --- > >>>>> arch/ia64/kernel/kprobes.c | 2 +- > >>>>> arch/x86/kernel/kprobes.c | 2 +- > >>>>> kernel/kprobes.c | 2 +- > >>>>> 3 files changed, 3 insertions(+), 3 deletions(-) > >>>> looks good, the x86 bits: > >>>> > >>>> Acked-by: Ingo Molnar > >>> man, we have too many config options:-) > >> > >> the non-x86 bits (kernel/kprobes.c) are crappy though, and broke -rc4 > >> allnoconfig: > >> > >> kernel/built-in.o: In function `collect_garbage_slots': > >> kprobes.c:(.kprobes.text+0x16e4): undefined reference to `freeze_processes' > >> kprobes.c:(.kprobes.text+0x16f2): undefined reference to `thaw_processes' > >> kprobes.c:(.kprobes.text+0x176b): undefined reference to `thaw_processes' > > > > Hmm, it seems that kernel/power/built-in.o was not linked to .tmp_vmlinux1. > > > > ld -m elf_i386 --build-id -o .tmp_vmlinux1 -T arch/x86/kernel/vmlinux.lds > > arch/x86/kernel/head_32.o arch/x86/kernel/head32.o arch/x86/kernel/head.o > > arch/x86/kernel/init_task.o init/built-in.o --start-group usr/built-in.o > > arch/x86/kernel/built-in.o arch/x86/mm/built-in.o arch/x86/mach-default/built-in.o > > arch/x86/crypto/built-in.o arch/x86/vdso/built-in.o kernel/built-in.o > > mm/built-in.o fs/built-in.o ipc/built-in.o security/built-in.o crypto/built-in.o > > block/built-in.o lib/lib.a arch/x86/lib/lib.a lib/built-in.o > > arch/x86/lib/built-in.o drivers/built-in.o sound/built-in.o firmware/built-in.o > > arch/x86/pci/built-in.o net/built-in.o --end-group > > kernel/built-in.o: In function `collect_garbage_slots': > > kprobes.c:(.kprobes.text+0x16e4): undefined reference to `freeze_processes' > > kprobes.c:(.kprobes.text+0x16f2): undefined reference to `thaw_processes' > > kprobes.c:(.kprobes.text+0x176b): undefined reference to `thaw_processes' > > > > At kernel/Makefile:53, I can see > > > > obj-$(CONFIG_PM) += power/ > > > > but CONFIG_PM was not set in config > > Sounds plausible. We need a fix for this - it's broken upstream. Hmm. Can || be used under obj-$() ? Rafael