From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Add eth_get_dev_by_index
Date: Wed, 11 Feb 2009 12:47:31 +0100 [thread overview]
Message-ID: <20090211114731.C0FD3832E893@gemini.denx.de> (raw)
In-Reply-To: <2acbd3e40902101743w5d9dc788lb05170769790103f@mail.gmail.com>
Dear Andy Fleming,
In message <2acbd3e40902101743w5d9dc788lb05170769790103f@mail.gmail.com> you wrote:
>
> > looks like a lot of pointless whitespace changes when there should just be 1
> > new line: the prototype
>
> They're not pointless, they fix it so that the lines are <= 80
> characters wide. The comments had extra spaces which made every line
> look like:
...
> If people think the whitespace changes are too much, I'll move them
> into a separate patch.
Yes, please split this into two patches. Thanks.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Artificial Intelligence is no match for natural stupidity.
next prev parent reply other threads:[~2009-02-11 11:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 0:55 [U-Boot] [PATCH] Add eth_get_dev_by_index Andy Fleming
2009-02-11 1:01 ` Mike Frysinger
2009-02-11 1:43 ` Andy Fleming
2009-02-11 2:44 ` Mike Frysinger
2009-02-11 11:47 ` Wolfgang Denk [this message]
2009-02-11 5:15 ` Ben Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090211114731.C0FD3832E893@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.