From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756896AbZBKWjK (ORCPT ); Wed, 11 Feb 2009 17:39:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750730AbZBKWi4 (ORCPT ); Wed, 11 Feb 2009 17:38:56 -0500 Received: from smtp1.linux-foundation.org ([140.211.169.13]:57033 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755061AbZBKWiz (ORCPT ); Wed, 11 Feb 2009 17:38:55 -0500 Date: Wed, 11 Feb 2009 14:38:44 -0800 From: Andrew Morton To: Giuseppe Bilotta Cc: linux-kernel@vger.kernel.org, eric.piel@tremplin-utc.net, pavel@suse.cz, giuseppe.bilotta@gmail.com Subject: Re: [PATCHv7] lis3lv02d: support both one- and two-byte sensors Message-Id: <20090211143844.27ca0d6c.akpm@linux-foundation.org> In-Reply-To: <1234346803-19811-1-git-send-email-giuseppe.bilotta@gmail.com> References: <49929EB8.4020802@tremplin-utc.net> <1234346803-19811-1-git-send-email-giuseppe.bilotta@gmail.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 11 Feb 2009 11:06:43 +0100 Giuseppe Bilotta wrote: > Sensors responding with 0x3B to WHO_AM_I only have one data register per > direction, thus returning a signed byte from the position which is > occupied by the MSB in sensors responding with 0x3A. > > Since multiple sensors share the reply to WHO_AM_I, we rename the > defines to better indicate what they identify (family of single and > double precision sensors). > > We support both kind of sensors by checking for the sensor type on init > and defining appropriate data-access routines and sensor limits (for the > joystick) depending on what we find. > Which tree is this patch against? > --- a/drivers/hwmon/lis3lv02d.c > +++ b/drivers/hwmon/lis3lv02d.c > @@ -53,9 +53,6 @@ > * joystick. > */ > > -/* Maximum value our axis may get for the input device (signed 12 bits) */ > -#define MDPS_MAX_VAL 2048 > - > struct acpi_lis3lv02d adev = { > .misc_wait = __WAIT_QUEUE_HEAD_INITIALIZER(adev.misc_wait), > }; Current Linus mainline has struct acpi_lis3lv02d adev; EXPORT_SYMBOL_GPL(adev); here. Also, this comment: /* * The sensor can also generate interrupts (DRDY) but it's pretty pointless * because their are generated even if the data do not change. So it's better * to keep the interrupt for the free-fall event. The values are updated at * 40Hz (at the lowest frequency), but as it can be pretty time consuming on * some low processor, we poll the sensor only at 20Hz... enough for the * joystick. */ seems to be describing something which isn't there.