All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: benh@kernel.crashing.org
Cc: airlied@linux.ie, dri-devel@lists.sourceforge.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5]: drm: ati_pcigart: Do not access I/O MEM space using pointer derefs.
Date: Thu, 12 Feb 2009 03:09:26 -0800 (PST)	[thread overview]
Message-ID: <20090212.030926.74125778.davem@davemloft.net> (raw)
In-Reply-To: <1234434959.29851.55.camel@pasglop>

From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Date: Thu, 12 Feb 2009 21:35:59 +1100

> Oh BTW something else to be careful with, though I suppose it's working
> some what by accident right now... when the GART is in the frame buffer
> it gets applied the current fb swapper setting... ouch !
> 
> So it might be a good idea, if we're going to use DRM_READ/WRITE32 which
> afaik are readl/writel (ie, swapping) to make sure we at least
> temporarily disable that swapper while whacking the GART.

Cute.

I wonder if this is what is tripping me up.

But, looking more closely, it appears that:

1) The kernel radeon framebuffer driver doesn't mess with
   the framebuffer endianness setting.

2) On >= R300 (which my chip is), Xorg leaves it alone too.

  reply	other threads:[~2009-02-12 11:09 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 10:15 [PATCH 1/5]: drm: ati_pcigart: Do not access I/O MEM space using pointer derefs David Miller
2009-02-12 10:35 ` Benjamin Herrenschmidt
2009-02-12 11:09   ` David Miller [this message]
2009-02-12 11:23     ` Dave Airlie
2009-02-12 22:17       ` David Miller
2009-02-12 21:26     ` Benjamin Herrenschmidt
2009-02-12 21:29       ` Benjamin Herrenschmidt
2009-02-14  6:09   ` David Miller
2009-02-14  7:42     ` Dave Airlie
2009-02-14  8:58       ` David Miller
2009-02-14  9:09       ` Benjamin Herrenschmidt
2009-02-14  9:07     ` Benjamin Herrenschmidt
2009-02-14  9:11       ` David Miller
2009-02-14  9:51         ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090212.030926.74125778.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=airlied@linux.ie \
    --cc=benh@kernel.crashing.org \
    --cc=dri-devel@lists.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.