From: Marcelo Tosatti <mtosatti@redhat.com>
To: Sheng Yang <sheng@linux.intel.com>
Cc: Avi Kivity <avi@redhat.com>, kvm@vger.kernel.org
Subject: Re: [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device
Date: Fri, 13 Feb 2009 15:13:14 -0200 [thread overview]
Message-ID: <20090213171314.GB24353@amt.cnet> (raw)
In-Reply-To: <200902131329.42960.sheng@linux.intel.com>
On Fri, Feb 13, 2009 at 01:29:42PM +0800, Sheng Yang wrote:
> The allocation only happen once, at the second time it would report error in
> current code. But allocate/deallocate is also acceptable for future.
Oops, it OK.
> > - interrupt context can read the table while kvm_vm_ioctl_set_msix_entry
> > is modifying it. So you either need to forbid more than one
> > kvm_vm_ioctl_set_msix_entry call in the lifetime of a guest (which
> > you can later allow when you support MSI table change), or handle
> > accesses from multiple contexes now. It seems forbidding is enough for
> > the moment from what you said.
>
> Yeah.
>
> But for the modifying the MSI-X table, the most critical problem is, current
> Linux didn't support it IIRC. So I have to disable MSI-X then enable it again
> with new table, and it would result in lost interrupt.
>
> So seems the most reasonable method is to modify pci_enable_msix() and related
> function's action to support this...
Alright, then just reply "[PATCH 1/3] KVM: Ioctls for init MSI-X entry"
with the minor comments reworked so Avi can apply.
Thanks.
next prev parent reply other threads:[~2009-02-13 17:13 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-11 8:08 [PATCH 0/3 v2] MSI-X enabling Sheng Yang
2009-02-11 8:08 ` [PATCH 1/3] KVM: Ioctls for init MSI-X entry Sheng Yang
2009-02-11 12:44 ` Avi Kivity
2009-02-12 6:28 ` Sheng Yang
2009-02-12 10:07 ` Sheng Yang
2009-02-12 18:46 ` Marcelo Tosatti
2009-02-16 3:18 ` Sheng Yang
2009-02-16 5:49 ` Sheng Yang
2009-02-16 23:23 ` Marcelo Tosatti
2009-02-17 1:35 ` Sheng Yang
2009-02-17 1:36 ` Sheng Yang
2009-02-11 8:08 ` [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X Sheng Yang
2009-02-12 19:51 ` Marcelo Tosatti
2009-02-13 3:37 ` Sheng Yang
2009-02-13 17:10 ` Marcelo Tosatti
2009-02-17 18:09 ` Avi Kivity
2009-02-18 1:33 ` Sheng Yang
2009-02-11 8:08 ` [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device Sheng Yang
2009-02-11 12:48 ` Avi Kivity
2009-02-12 6:03 ` Sheng Yang
2009-02-12 20:40 ` Marcelo Tosatti
2009-02-13 5:29 ` Sheng Yang
2009-02-13 17:13 ` Marcelo Tosatti [this message]
2009-02-18 9:44 [PATCH 0/3 v3] MSI-X enabling Sheng Yang
2009-02-18 9:44 ` [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device Sheng Yang
2009-02-18 10:45 ` Avi Kivity
2009-02-18 12:24 ` Sheng Yang
2009-02-18 12:36 ` Avi Kivity
2009-02-18 12:52 ` Sheng Yang
2009-02-25 9:22 [PATCH 0/3 v4][Resend] MSI-X enabling Sheng Yang
2009-02-25 9:22 ` [PATCH 3/3] KVM: Enable MSI-X for KVM assigned device Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090213171314.GB24353@amt.cnet \
--to=mtosatti@redhat.com \
--cc=avi@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=sheng@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.