All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: the arch/x86 maintainers <x86@kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
Date: Fri, 13 Feb 2009 19:49:26 +0100	[thread overview]
Message-ID: <20090213184926.GA32338@elte.hu> (raw)
In-Reply-To: <4995BF9F.2050509@goop.org>


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Ingo Molnar wrote:
>> From beb6943d8df7ce9278282101af4e0f6f7b648451 Mon Sep 17 00:00:00 2001
>> From: Ingo Molnar <mingo@elte.hu>
>> Date: Fri, 13 Feb 2009 13:36:47 +0100
>> Subject: [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__
>>   
>
> I think this is wrong in principle.  There should never be a reason to  
> include a non-_types.h into asm.
>
> (Fine as a build fix, of course.)

Agreed - but it needs fixes to the .S files, these assembly files
include pgtable.h or page.h:

arch/x86/boot/compressed/head_32.S
arch/x86/boot/compressed/head_64.S
arch/x86/boot/header.S
arch/x86/kernel/acpi/realmode/wakeup.S
arch/x86/kernel/acpi/wakeup_32.S
arch/x86/kernel/acpi/wakeup_64.S
arch/x86/kernel/efi_stub_32.S
arch/x86/kernel/entry_32.S
arch/x86/kernel/entry_64.S
arch/x86/kernel/head_32.S
arch/x86/kernel/head_64.S
arch/x86/kernel/relocate_kernel_32.S
arch/x86/kernel/relocate_kernel_64.S
arch/x86/kernel/trampoline_32.S
arch/x86/kernel/trampoline_64.S
arch/x86/kernel/vmlinux_32.lds.S
arch/x86/kernel/vmlinux_64.lds.S
arch/x86/lib/getuser.S
arch/x86/power/hibernate_asm_32.S
arch/x86/power/hibernate_asm_64.S
arch/x86/xen/xen-head.S

	Ingo

  reply	other threads:[~2009-02-13 18:49 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-11 23:23 [GIT PULL] clean header untangling Jeremy Fitzhardinge
2009-02-13 12:02 ` Ingo Molnar
2009-02-13 12:18   ` [PATCH] x86 headers: remove duplicate pud_large() definition Ingo Molnar
2009-02-13 12:23     ` [PATCH] x86 headers: include linux/types.h Ingo Molnar
2009-02-13 12:27       ` Ingo Molnar
2009-02-13 12:37         ` [PATCH] x86 headers: protect page_32.h via __ASSEMBLY__ Ingo Molnar
2009-02-13 18:44           ` Jeremy Fitzhardinge
2009-02-13 18:49             ` Ingo Molnar [this message]
2009-02-13 18:52               ` Jeremy Fitzhardinge
2009-02-13 18:57                 ` Ingo Molnar
2009-02-13 16:25         ` [PATCH] x86 headers: include linux/types.h Jeremy Fitzhardinge
2009-02-13 18:09           ` Ingo Molnar
2009-02-16 21:00             ` Jeremy Fitzhardinge
2009-02-13 18:52       ` Jeremy Fitzhardinge
2009-02-13 18:55         ` Ingo Molnar
2009-02-13 18:59           ` Jeremy Fitzhardinge
2009-02-13 20:05             ` Ingo Molnar
2009-02-13 18:57         ` Jaswinder Singh Rajput
2009-02-13 16:27     ` [PATCH] x86 headers: remove duplicate pud_large() definition Jeremy Fitzhardinge
2009-02-13 18:02       ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090213184926.GA32338@elte.hu \
    --to=mingo@elte.hu \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.