From: Adam Baker <linux@baker-net.org.uk>
To: linux-media@vger.kernel.org
Cc: "Jean-Francois Moine" <moinejf@free.fr>,
kilgota@banach.math.auburn.edu,
"Hans Verkuil" <hverkuil@xs4all.nl>,
Olivier Lorin <o.lorin@laposte.net>,
Hans de Goede <hdegoede@redhat.com>
Subject: Adding a control for Sensor Orientation
Date: Sat, 14 Feb 2009 20:48:51 +0000 [thread overview]
Message-ID: <200902142048.51863.linux@baker-net.org.uk> (raw)
Hi all,
Hans Verkuil put forward a convincing argument that sensor orientation
shouldn't be part of the buffer flags as then it would be unavailable to
clients that use read() so it looks like implementing a read only control is
the only appropriate option.
It seems that Sensor Orientation is an attribute that many cameras may want to
expose so it shouldn't be a private control. Olivier Lorin's example patch
created a new CAMERA_PROPERTIES class. I'm not sure that a new class is
really justified so would like to hear other views on where the control
should live (and also if everyone is happy with Hans Verkuil's suggested name
of SENSOR_ORIENTATION which I prefer to Olivier Lorin's SENSOR_UPSIDE_DOWN as
we want to represent HFLIP and VFLIP as well as upside down (which as
currently implemented means 180 degree rotation.))
Assuming that it is considered inappropriate to add a new control as
an "Old-style 'user' control" then it is also, I presume, necessary to extend
gspca to support VIDIOC_G_EXT_CTRLS as at the moment it requires all control
access to use VIDIOC_G_CTRL. Would doing this conflict with anything anyone
else may be working on such as conversion to use v4l2_device.
Thoughts please.
Adam Baker
next reply other threads:[~2009-02-14 20:48 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-14 20:48 Adam Baker [this message]
2009-02-14 21:04 ` Adding a control for Sensor Orientation Hans Verkuil
2009-02-14 21:55 ` Hans de Goede
2009-02-14 21:59 ` Hans Verkuil
2009-02-14 22:44 ` kilgota
2009-02-15 9:08 ` Hans de Goede
2009-02-15 9:19 ` Hans Verkuil
2009-02-15 9:29 ` Hans de Goede
2009-02-15 13:03 ` Trent Piepho
2009-02-15 13:46 ` Hans de Goede
2009-02-15 23:09 ` Trent Piepho
2009-02-16 1:46 ` kilgota
2009-02-16 3:47 ` hermann pitton
2009-02-16 3:55 ` Trent Piepho
2009-02-16 8:30 ` Hans de Goede
2009-02-16 2:26 ` Mauro Carvalho Chehab
2009-02-16 4:04 ` Trent Piepho
2009-02-16 7:44 ` Hans Verkuil
2009-02-16 8:37 ` Hans de Goede
2009-02-16 8:33 Hans Verkuil
2009-02-16 22:36 ` Adam Baker
2009-02-17 2:00 ` kilgota
2009-02-17 7:27 ` Hans Verkuil
2009-02-17 22:29 ` Adam Baker
2009-02-16 8:57 Hans Verkuil
2009-02-16 9:07 Hans Verkuil
2009-02-16 9:44 ` Hans de Goede
2009-02-16 11:11 ` Mauro Carvalho Chehab
2009-02-16 12:19 ` Hans de Goede
2009-02-16 14:20 ` Mauro Carvalho Chehab
2009-02-16 15:00 ` Mauro Carvalho Chehab
2009-02-16 15:24 ` Hans de Goede
2009-02-16 11:01 Hans Verkuil
2009-02-16 11:12 ` Jean-Francois Moine
2009-02-16 12:07 ` Hans de Goede
2009-02-16 12:02 Hans Verkuil
2009-02-16 14:00 Hans Verkuil
2009-02-16 14:25 ` Hans de Goede
2009-02-16 16:09 ` Trent Piepho
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200902142048.51863.linux@baker-net.org.uk \
--to=linux@baker-net.org.uk \
--cc=hdegoede@redhat.com \
--cc=hverkuil@xs4all.nl \
--cc=kilgota@banach.math.auburn.edu \
--cc=linux-media@vger.kernel.org \
--cc=moinejf@free.fr \
--cc=o.lorin@laposte.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.