From: Jeff King <peff@peff.net>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 2/8] config: Cleanup config file handling.
Date: Sun, 15 Feb 2009 15:15:06 -0500 [thread overview]
Message-ID: <20090215201505.GC26779@coredump.intra.peff.net> (raw)
In-Reply-To: <1234688460-9248-2-git-send-email-felipe.contreras@gmail.com>
On Sun, Feb 15, 2009 at 11:00:54AM +0200, Felipe Contreras wrote:
> As suggested by Johannes Schindelin.
Thank you for splitting this patch up. I have to admit I was too scared
to read the original after seeing the diffstat.
But part of the nice thing about splitting up is that you can write
meaningful commit messages for each individual change. Reading this
commit message, I don't know what to expect.
Your 1/8, though short, tells me what to expect: a trivial rename. But
"clean up config file handling" is quite ambiguous. And after reading
the patch, I am left wondering why the filename and errno are not useful
as part of the die() message. I think even a single sentence would
probably make it clear.
And yes, I know I can look elsewhere in the thread to find the
discussion between you and Dscho. But think of the poor "git log" user
six months from now.
-Peff
next prev parent reply other threads:[~2009-02-15 20:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-15 9:00 [PATCH 1/8] config: Trivial rename in preparation for parseopt Felipe Contreras
2009-02-15 9:00 ` [PATCH 2/8] config: Cleanup config file handling Felipe Contreras
2009-02-15 9:00 ` [PATCH 3/8] config: Use parseopt Felipe Contreras
2009-02-15 9:00 ` [PATCH 4/8] config: Improve variable 'type' handling Felipe Contreras
2009-02-15 9:00 ` [PATCH 5/8] config: Disallow multiple config file locations Felipe Contreras
2009-02-15 9:00 ` [PATCH 6/8] config: Don't allow extra arguments for -e or -l Felipe Contreras
2009-02-15 9:00 ` [PATCH 7/8] config: Don't return negative exit codes Felipe Contreras
2009-02-15 9:01 ` [PATCH 8/8] config: Codestyle cleanups Felipe Contreras
2009-02-15 12:22 ` [PATCH 7/8] config: Don't return negative exit codes Johannes Schindelin
2009-02-15 12:39 ` Felipe Contreras
2009-02-15 13:30 ` Felipe Contreras
2009-02-15 12:26 ` [PATCH 5/8] config: Disallow multiple config file locations Johannes Schindelin
2009-02-15 12:44 ` Felipe Contreras
2009-02-15 13:35 ` Felipe Contreras
2009-02-15 12:24 ` [PATCH 4/8] config: Improve variable 'type' handling Johannes Schindelin
2009-02-15 12:43 ` Felipe Contreras
2009-02-15 13:34 ` Felipe Contreras
2009-02-15 20:15 ` Jeff King [this message]
2009-02-16 1:15 ` [PATCH 2/8] config: Cleanup config file handling Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090215201505.GC26779@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.