From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sheng Yang Subject: Re: [PATCH 2/3] KVM: Add gsi_msg_pending_bitmap for MSI-X Date: Wed, 18 Feb 2009 09:33:39 +0800 Message-ID: <200902180933.40296.sheng@linux.intel.com> References: <1234339731-3195-1-git-send-email-sheng@linux.intel.com> <200902131137.47240.sheng@linux.intel.com> <499AFD6D.5090607@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Cc: Marcelo Tosatti , kvm@vger.kernel.org To: Avi Kivity Return-path: Received: from mga09.intel.com ([134.134.136.24]:53626 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752268AbZBRBdo (ORCPT ); Tue, 17 Feb 2009 20:33:44 -0500 In-Reply-To: <499AFD6D.5090607@redhat.com> Content-Disposition: inline Sender: kvm-owner@vger.kernel.org List-ID: On Wednesday 18 February 2009 02:09:49 Avi Kivity wrote: > Sheng Yang wrote: > >>> + if (assigned_dev->irq_requested_type == KVM_ASSIGNED_DEV_MSIX) { > >>> + u32 gsi; > >>> + gsi = find_gsi_from_host_irq(assigned_dev, irq); > >>> + if (gsi == 0) > >>> + return IRQ_HANDLED; > >> > >> So you chose GSI == 0 as invalid because of x86 assumptions? Or is there > >> any other reason? > > > > Yeah, it based on x86 and IA64 IRQ 0 can't be used by MSI-X. And only x86 > > support MSI-X now(and IA64 would follow later). > > gsi != irq... as used in kvm it is just a cookie and is never visible to > the guest. I'd prefer an illegal value here. > > > Also, please repost the entire patchset so I can be sure I apply the > latest; too many versions floating around. OK. And please don't forget there is a patchset named "Optimize and unify IOAPIC/MSI delivery" before this one. :) -- regards Yang, Sheng