All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Felipe Balbi <me@felipebalbi.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, linux-omap@vger.kernel.org
Subject: Re: [PATCH 07/13] ARM: OMAP: No need to include board-omap2430sdp.h from hardware.h
Date: Thu, 26 Feb 2009 19:11:05 -0800	[thread overview]
Message-ID: <20090227031105.GC13869@atomide.com> (raw)
In-Reply-To: <20090227001354.GF6070@gandalf>

* Felipe Balbi <me@felipebalbi.com> [090226 16:14]:
> Nothing to do with this patch in particular, but...
> 
> On Thu, Feb 26, 2009 at 04:01:15PM -0800, Tony Lindgren wrote:
> > @@ -102,8 +105,8 @@ static struct resource sdp2430_smc91x_resources[] = {
> >  		.flags	= IORESOURCE_MEM,
> >  	},
> >  	[1] = {
> > -		.start	= OMAP_GPIO_IRQ(OMAP24XX_ETHR_GPIO_IRQ),
> > -		.end	= OMAP_GPIO_IRQ(OMAP24XX_ETHR_GPIO_IRQ),
> > +		.start	= OMAP_GPIO_IRQ(SDP2430_ETHR_GPIO_IRQ),
> > +		.end	= OMAP_GPIO_IRQ(SDP2430_ETHR_GPIO_IRQ),
> >  		.flags	= IORESOURCE_IRQ | IORESOURCE_IRQ_LOWLEVEL,
> 
> normally we only pass start and this should probably be using
> gpio_to_irq(), but for that...
> 
> >  	},
> >  };
> > @@ -170,13 +173,13 @@ static inline void __init sdp2430_init_smc91x(void)
> >  	sdp2430_smc91x_resources[0].end = cs_mem_base + 0x30f;
> >  	udelay(100);
> >  
> > -	if (gpio_request(OMAP24XX_ETHR_GPIO_IRQ, "SMC91x irq") < 0) {
> > +	if (gpio_request(SDP2430_ETHR_GPIO_IRQ, "SMC91x irq") < 0) {
> >  		printk(KERN_ERR "Failed to request GPIO%d for smc91x IRQ\n",
> > -			OMAP24XX_ETHR_GPIO_IRQ);
> > +			SDP2430_ETHR_GPIO_IRQ);
> >  		gpmc_cs_free(eth_cs);
> >  		goto out;
> >  	}
> > -	gpio_direction_input(OMAP24XX_ETHR_GPIO_IRQ);
> > +	gpio_direction_input(SDP2430_ETHR_GPIO_IRQ);
> 
> we should probably add:
> 
> sdp2430_scm91x_resources[1].start = gpio_to_irq(OMAP24XX_ETHER_GPIO_IRQ);
> 
> here

Yeah. But let's deal with that a bit later as I'm thinking about
having a omap generic smc91x_init() which sets the GPMC timings too.

The problem with the current GPMC timings is that they are not cpufreq
safe as they are not dynamically calculated.

Regards,

Tony

  reply	other threads:[~2009-02-27  3:11 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-26 23:52 [PATCH 00/13] Omap header clean-up for next merge window Tony Lindgren
2009-02-26 23:53 ` [PATCH 01/13] ARM: OMAP: No need to include board-perseus2.h or board-fsample.h from hardware.h Tony Lindgren
2009-02-26 23:54 ` [PATCH 02/13] ARM: OMAP: No need to include board-h2.h " Tony Lindgren
2009-02-26 23:56 ` [PATCH 03/13] ARM: OMAP: No need to include board-h3.h " Tony Lindgren
2009-02-26 23:57 ` [PATCH 04/13] ARM: OMAP: No need to include board-innovator.h " Tony Lindgren
2009-02-26 23:58 ` [PATCH 05/13] ARM: OMAP: No need to include board-osk.h " Tony Lindgren
2009-02-26 23:59 ` [PATCH 06/13] ARM: OMAP: No need to include board-palm*.h " Tony Lindgren
2009-02-27  0:01 ` [PATCH 07/13] ARM: OMAP: No need to include board-omap2430sdp.h " Tony Lindgren
2009-02-27  0:13   ` Felipe Balbi
2009-02-27  3:11     ` Tony Lindgren [this message]
2009-02-27  0:02 ` [PATCH 08/13] ARM: OMAP: No need to include board-apollon.h " Tony Lindgren
2009-02-27  0:03 ` [PATCH 09/13] ARM: OMAP: No need to include board-h4.h " Tony Lindgren
2009-02-27  0:05 ` [PATCH 10/13] ARM: OMAP: No need to include board-ldp.h " Tony Lindgren
2009-02-27  0:06 ` [PATCH 11/13] ARM: OMAP: No need to include board-overo.h " Tony Lindgren
2009-02-27  0:07 ` [PATCH 12/13] ARM: OMAP: No need to include board-nokia.h " Tony Lindgren
2009-02-27  0:08 ` [PATCH 13/13] ARM: OMAP: Remove remaining board-*.h includes " Tony Lindgren
2009-02-27 20:11 ` [PATCH 00/13] Omap header clean-up for next merge window Russell King - ARM Linux
2009-03-04 17:53   ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090227031105.GC13869@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-omap@vger.kernel.org \
    --cc=me@felipebalbi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.