All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Peter Feuerer <peter@piie.net>
Cc: Joe Perches <joe@perches.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] acerhdf: Acer Aspire One fan control
Date: Sun, 1 Mar 2009 14:38:51 +0000	[thread overview]
Message-ID: <20090301143851.GA11852@srcf.ucam.org> (raw)
In-Reply-To: <cone.1235847508.919525.5537.1000@onepiie>

Small number of things:

*) It looks like the patch has ended up linewrapped - it probably won't 
apply as a result.

*) x86 specific drivers are mostly moving from drivers/misc to 
drivers/platform/x86.

*) It should probably have a DMI modalias to allow it to autoload on 
appropriate hardware.

*) You have user and kernel modes - it should probably also have a bios 
mode that just leaves fan control in the same state it would be if the 
driver had never been loaded, and this should be the default.

*) The thermal code has been moved from ACPI into the generic thermal 
layer for 2.6.30. If you register thermal trip points and indicate that 
you require polling you should be able to get rid of the kernel thread 
in your driver and leave that up to the kernel.

Once that's all dealt with you should submit the patch to linux-kernel 
and Cc: Len Brown who maintains drivers/platform/x86. Include a 
description and a signed-off-by: line (and an entry in the MAINTAINERS 
file) and it should get merged.

-- 
Matthew Garrett | mjg59@srcf.ucam.org

  reply	other threads:[~2009-03-01 14:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-12 20:37 Acer Aspire One fan control Peter Feuerer
2009-02-12 21:03 ` Ralf Hildebrandt
2009-02-12 21:14   ` Peter Feuerer
2009-03-09 10:54     ` Maxim Levitsky
2009-02-13 10:35 ` Thomas Renninger
2009-02-13 19:34   ` Peter Feuerer
2009-02-13 13:40 ` Matthew Garrett
2009-02-13 18:59   ` Peter Feuerer
2009-02-13 19:18     ` Matthew Garrett
2009-02-13 19:45       ` Peter Feuerer
2009-02-27 18:58       ` [PATCH] acerhdf: " Peter Feuerer
     [not found]         ` <1235763653.24506.6.camel@localhost>
2009-02-28 18:58           ` Peter Feuerer
2009-03-01 14:38             ` Matthew Garrett [this message]
2009-03-26 22:22               ` Peter Feuerer
2009-04-01 12:44                 ` Peter Feuerer
2009-04-12 20:49                   ` Peter Feuerer
2009-04-04 10:51                 ` Peter Feuerer
2009-03-01 15:27             ` Ed Tomlinson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090301143851.GA11852@srcf.ucam.org \
    --to=mjg59@srcf.ucam.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@piie.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.