From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gleb Natapov Subject: Re: x86: use smp_send_reschedule in kvm_vcpu_kick Date: Tue, 3 Mar 2009 15:25:57 +0200 Message-ID: <20090303132557.GH15254@redhat.com> References: <20090303001405.GA5889@amt.cnet> <706158FABBBA044BAD4FE898A02E4BC22435AFBA@pdsmsx503.ccr.corp.intel.com> <20090303132520.GD15492@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: "Zhang, Xiantao" , "kvm@vger.kernel.org" , Ingo Molnar , Peter Zijlstra To: Marcelo Tosatti Return-path: Received: from mx2.redhat.com ([66.187.237.31]:53806 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755658AbZCCN30 (ORCPT ); Tue, 3 Mar 2009 08:29:26 -0500 Content-Disposition: inline In-Reply-To: <20090303132520.GD15492@amt.cnet> Sender: kvm-owner@vger.kernel.org List-ID: On Tue, Mar 03, 2009 at 10:25:20AM -0300, Marcelo Tosatti wrote: > On Tue, Mar 03, 2009 at 03:53:50PM +0800, Zhang, Xiantao wrote: > > Marcelo Tosatti wrote: > > > @@ -72,7 +73,6 @@ struct kvm_vcpu { > > > struct mutex mutex; > > > int cpu; > > > struct kvm_run *run; > > > - int guest_mode; > > > unsigned long requests; > > > unsigned long guest_debug; > > > int fpu_active; > > > > The deletion will break other archs which depend on the filed. > > Indeed. Will keep it, thanks. The only other arch is ia64 and its kvm_vcpu_kick() should be fixed the same way. No? -- Gleb.