From mboxrd@z Thu Jan  1 00:00:00 1970
From: Marcelo Tosatti <mtosatti@redhat.com>
Subject: Re: x86: use smp_send_reschedule in kvm_vcpu_kick
Date: Tue, 3 Mar 2009 10:56:21 -0300
Message-ID: <20090303135621.GA16341@amt.cnet>
References: <20090303001405.GA5889@amt.cnet> <706158FABBBA044BAD4FE898A02E4BC22435AFBA@pdsmsx503.ccr.corp.intel.com> <20090303132520.GD15492@amt.cnet> <20090303132557.GH15254@redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: "Zhang, Xiantao" <xiantao.zhang@intel.com>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
	Ingo Molnar <mingo@elte.hu>,
	Peter Zijlstra <peter@programming.kicks-ass.net>
To: Gleb Natapov <gleb@redhat.com>
Return-path: <kvm-owner@vger.kernel.org>
Received: from mx2.redhat.com ([66.187.237.31]:51127 "EHLO mx2.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1750750AbZCCN50 (ORCPT <rfc822;kvm@vger.kernel.org>);
	Tue, 3 Mar 2009 08:57:26 -0500
Content-Disposition: inline
In-Reply-To: <20090303132557.GH15254@redhat.com>
Sender: kvm-owner@vger.kernel.org
List-ID: <kvm.vger.kernel.org>

On Tue, Mar 03, 2009 at 03:25:57PM +0200, Gleb Natapov wrote:
> On Tue, Mar 03, 2009 at 10:25:20AM -0300, Marcelo Tosatti wrote:
> > On Tue, Mar 03, 2009 at 03:53:50PM +0800, Zhang, Xiantao wrote:
> > > Marcelo Tosatti wrote:
> > > > @@ -72,7 +73,6 @@ struct kvm_vcpu {
> > > >  	struct mutex mutex;
> > > >  	int   cpu;
> > > >  	struct kvm_run *run;
> > > > -	int guest_mode;
> > > >  	unsigned long requests;
> > > >  	unsigned long guest_debug;
> > > >  	int fpu_active;
> > > 
> > > The deletion will break other archs which depend on the filed. 
> > 
> > Indeed. Will keep it, thanks.
> The only other arch is ia64 and its kvm_vcpu_kick() should be fixed
> the same way. No?

Probably yes.