From: David Brownell <david-b@pacbell.net>
To: Liam Girdwood <lrg@slimlogic.co.uk>
Cc: Mark Brown <broonie@sirena.org.uk>,
lkml <linux-kernel@vger.kernel.org>,
OMAP <linux-omap@vger.kernel.org>
Subject: Re: [patch/rfc 2.6.29-rc6 2/2] regulator: twl4030 voltage enumeration (v2)
Date: Tue, 3 Mar 2009 14:59:59 -0800 [thread overview]
Message-ID: <200903031500.00166.david-b@pacbell.net> (raw)
In-Reply-To: <1235737930.31223.117.camel@vega.slimlogic.co.uk>
On Friday 27 February 2009, Liam Girdwood wrote:
> Sorry, this didn't apply. It looks like I'm missing an earlier patch(s)
> here. Could you regenerate this and your core patch against latest
> for-next.
Here you go.
- Dave
========== CUT HERE
From: David Brownell <dbrownell@users.sourceforge.net>
Minor cleanups to the twl403 regulator driver, mostly enabled
by other recent changes: comments, shrink memory usage, add
definition for one bit.
Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
---
drivers/regulator/twl4030-regulator.c | 16 +++++++++-------
1 file changed, 9 insertions(+), 7 deletions(-)
--- a/drivers/regulator/twl4030-regulator.c
+++ b/drivers/regulator/twl4030-regulator.c
@@ -36,13 +36,13 @@ struct twlreg_info {
/* twl4030 resource ID, for resource control state machine */
u8 id;
+ /* FIXED_LDO voltage */
+ u8 deciV;
+
/* voltage in mV = table[VSEL]; table_len must be a power-of-two */
u8 table_len;
const u16 *table;
- /* chip constraints on regulator behavior */
- u16 min_mV;
-
/* used by regulator core */
struct regulator_desc desc;
};
@@ -93,6 +93,7 @@ static int twl4030reg_grp(struct regulat
#define P3_GRP BIT(7) /* "peripherals" */
#define P2_GRP BIT(6) /* secondary processor, modem, etc */
#define P1_GRP BIT(5) /* CPU/Linux */
+#define WARM_CFG BIT(4)
static int twl4030reg_is_enabled(struct regulator_dev *rdev)
{
@@ -325,14 +326,14 @@ static int twl4030fixed_list_voltage(str
{
struct twlreg_info *info = rdev_get_drvdata(rdev);
- return info->min_mV * 1000;
+ return info->deciV * 100 * 1000;
}
static int twl4030fixed_get_voltage(struct regulator_dev *rdev)
{
struct twlreg_info *info = rdev_get_drvdata(rdev);
- return info->min_mV * 1000;
+ return info->deciV * 100 * 1000;
}
static struct regulator_ops twl4030fixed_ops = {
@@ -369,7 +370,7 @@ static struct regulator_ops twl4030fixed
#define TWL_FIXED_LDO(label, offset, mVolts, num) { \
.base = offset, \
.id = num, \
- .min_mV = mVolts, \
+ .deciV = mVolts / 100 , \
.desc = { \
.name = #label, \
.id = TWL4030_REG_##label, \
@@ -381,7 +382,7 @@ static struct regulator_ops twl4030fixed
}
/*
- * We list regulators here if systems need some level of
+ * We expose regulators here if systems need some level of
* software control over them after boot.
*/
static struct twlreg_info twl4030_regs[] = {
@@ -435,6 +436,7 @@ static int twl4030reg_probe(struct platf
/* Constrain board-specific capabilities according to what
* this driver and the chip itself can actually do.
+ * (Regulator core now does this for voltage constraints.)
*/
c = &initdata->constraints;
c->valid_modes_mask &= REGULATOR_MODE_NORMAL | REGULATOR_MODE_STANDBY;
next prev parent reply other threads:[~2009-03-03 23:00 UTC|newest]
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-08 18:37 [patch 2.6.29-rc3-git 1/2] regulator: twl4030 regulators David Brownell
2009-02-08 23:29 ` Mark Brown
2009-02-09 0:04 ` David Brownell
2009-02-09 0:04 ` David Brownell
2009-02-09 17:27 ` Mark Brown
2009-02-10 0:24 ` David Brownell
2009-02-10 22:48 ` Mark Brown
2009-02-23 20:45 ` David Brownell
2009-02-23 20:52 ` [patch/rfc 2.6.29-rc6 1/2] regulator: enumerate voltages David Brownell
2009-02-24 22:23 ` Mark Brown
2009-02-25 0:17 ` David Brownell
2009-02-25 15:17 ` Mark Brown
2009-02-25 22:12 ` David Brownell
2009-02-25 23:01 ` Mark Brown
2009-02-25 23:47 ` David Brownell
2009-02-25 23:47 ` David Brownell
2009-02-26 11:05 ` Mark Brown
2009-02-26 1:02 ` David Brownell
2009-02-26 1:02 ` David Brownell
2009-02-26 10:46 ` Mark Brown
2009-02-26 18:56 ` David Brownell
2009-02-26 19:05 ` Mark Brown
2009-02-26 19:38 ` David Brownell
2009-02-26 20:02 ` Liam Girdwood
2009-02-26 20:59 ` David Brownell
2009-02-26 20:59 ` David Brownell
2009-02-26 19:48 ` [patch 2.6.29-rc6 1/2] regulator: enumerate voltages (v2) David Brownell
2009-02-26 20:20 ` Mark Brown
2009-02-26 21:12 ` David Brownell
2009-02-26 21:48 ` [patch 2.6.29-rc6+misc] MMC: regulator utilities David Brownell
2009-03-02 20:59 ` Pierre Ossman
2009-03-02 21:27 ` David Brownell
2009-03-02 21:40 ` Pierre Ossman
2009-03-02 22:00 ` David Brownell
2009-03-04 3:18 ` David Brownell
2009-03-08 13:59 ` Pierre Ossman
2009-03-08 20:34 ` David Brownell
2009-03-08 21:49 ` Pierre Ossman
2009-03-09 11:52 ` Liam Girdwood
2009-03-11 11:30 ` David Brownell
2009-03-11 14:34 ` Liam Girdwood
2009-02-26 20:53 ` [patch 2.6.29-rc6 1/2] regulator: enumerate voltages (v2) Liam Girdwood
2009-02-26 21:28 ` David Brownell
2009-02-26 21:58 ` Liam Girdwood
2009-02-27 0:10 ` David Brownell
2009-02-23 20:54 ` [patch/rfc 2.6.29-rc6 2/2] regulator: twl4030 voltage enumeration David Brownell
2009-02-26 19:50 ` [patch/rfc 2.6.29-rc6 2/2] regulator: twl4030 voltage enumeration (v2) David Brownell
2009-02-26 20:25 ` Mark Brown
2009-02-26 22:16 ` Liam Girdwood
2009-02-27 0:02 ` David Brownell
2009-02-27 0:02 ` David Brownell
2009-02-27 12:32 ` Liam Girdwood
2009-02-27 20:39 ` David Brownell
2009-02-27 21:26 ` Liam Girdwood
2009-03-03 22:59 ` David Brownell [this message]
2009-03-04 11:47 ` Liam Girdwood
2009-02-23 22:04 ` [patch 2.6.29-rc3-git 1/2] regulator: twl4030 regulators Mark Brown
2009-02-23 22:43 ` David Brownell
2009-02-24 0:55 ` Mark Brown
2009-02-24 2:03 ` David Brownell
2009-02-24 12:41 ` Mark Brown
2009-02-24 2:22 ` David Brownell
2009-02-24 2:22 ` David Brownell
2009-02-24 7:25 ` David Brownell
2009-02-24 7:25 ` David Brownell
2009-02-26 22:15 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200903031500.00166.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=broonie@sirena.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.