Re: [PATCH 2/4] soc-dai: add bitfields for hardware I2S formats

From: Daniel Mack <daniel@caiaq.de>
To: Mark Brown <broonie@sirena.org.uk>
Cc: alsa-devel@alsa-project.org, Tim Ruetz <tim@caiaq.de>,
	Liam Girdwood <lrg@kernel.org>
Subject: Re: [PATCH 2/4] soc-dai: add bitfields for hardware	I2S formats
Date: Thu, 5 Mar 2009 13:55:21 +0100	[thread overview]
Message-ID: <20090305125521.GB29699@buzzloop.caiaq.de> (raw)
In-Reply-To: <20090305120335.GF2416@sirena.org.uk>

On Thu, Mar 05, 2009 at 12:03:35PM +0000, Mark Brown wrote:
> > > The other option would be to use the TDM mode interface to set this up
> > > since that's roughly what it is; my main concern here is that we already
> > > have two ways of doing this and I'd like to try to keep the number down
> > > for consistency.
> 
> > Probably a matter of taste, but IMO TDM mode is not the place either.
> > Userspace could decide sending out 24bit samples out of a sudden (which
> > the CPU DAI might accept) and in this case, you'd need some special
> > logic in the board file again to set up deviders, time slots etc, right?
> 
> That's why the clocking interface is generally used here - it's more
> orthogonal.

Hmm, how would you express 24 sample bits with 32 clocks per channel? I
might not have gotten your point yet - could you provide an example?

Daniel