From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 09 Mar 2009 00:33:59 +0100 Subject: [U-Boot] [PATCH 8/9] at91sam9263ek add dcc support with at91sam9263ek_dcc_config In-Reply-To: <1236089265-24598-8-git-send-email-plagnioj@jcrosoft.com> References: <1236089265-24598-1-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-2-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-3-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-4-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-5-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-6-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-7-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-8-git-send-email-plagnioj@jcrosoft.com> Message-ID: <20090308233359.9E610832E8B8@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe PLAGNIOL-VILLARD, In message <1236089265-24598-8-git-send-email-plagnioj@jcrosoft.com> you wrote: > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD > --- > Makefile | 11 +++++++++++ > include/configs/at91sam9263ek.h | 2 ++ > 2 files changed, 13 insertions(+), 0 deletions(-) > > diff --git a/Makefile b/Makefile > index 784af52..50ce78e 100644 > --- a/Makefile > +++ b/Makefile > @@ -2687,6 +2687,8 @@ at91sam9261ek_config : unconfig > at91sam9263ek_nandflash_config \ > at91sam9263ek_dataflash_config \ > at91sam9263ek_dataflash_cs0_config \ > +at91sam9263ek_dcc_multi_config \ > +at91sam9263ek_dcc_config \ > at91sam9263ek_wdt_config \ > at91sam9263ek_config : unconfig NAK. NAK. NAK. As explained before, this makes no sense. Why could we not have DCC support with any of the other options? Also, you are adding more and more cruft to the Makefile. This is not acceptable. Finally, there should be some commit message that explains what you are doing. For example, you should at least give a minimal explanation what DCC is and why we might want to add this.... Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de You can't evaluate a man by logic alone. -- McCoy, "I, Mudd", stardate 4513.3