From mboxrd@z Thu Jan 1 00:00:00 1970 From: Simon Horman Subject: Re: [patch] HVM: Expand the number of PCI interrupts from 16 to 32 Date: Mon, 9 Mar 2009 20:20:47 +1100 Message-ID: <20090309092047.GB8436@verge.net.au> References: <20090308234803.GA31771@verge.net.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Yuji Shimada , Xen-devel List-Id: xen-devel@lists.xenproject.org On Mon, Mar 09, 2009 at 09:17:30AM +0000, Keir Fraser wrote: > On 08/03/2009 23:48, "Simon Horman" wrote: > > > I'm not sure what the reason for this, but the tables relating > > to PCI interrupts seem to be truncated to 15 entries. I am > > guessing that they are just incomplete and that this has never > > been an issue. This patch extends these tables to the full 32 entries. > > > > Tested by giving an ioemu rtl8139 device pci device 24, > > which is unable to communicate with the network without this change. > > The rombios.c change was optimistic (you changed the bytes-per-device value, > rather than the number-of-devices value). The rombios table actually already > only describes 6 PCI devices, and expanding it further may risk overflowing > the available space in the ROM image. Any OS we pass devices to is going to > be ACPI-enabled anyway, so it doesn't matter. > > The DSDT changes had some bugs -- the LNK[ABCD] values were mostly wrong, > and the GSI values for Device 23 Links C&D were wrong. Thanks, sorry for the misses. -- Simon Horman VA Linux Systems Japan K.K., Sydney, Australia Satellite Office H: www.vergenet.net/~horms/ W: www.valinux.co.jp/en