From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Mon, 9 Mar 2009 12:18:35 +0100
Subject: [U-Boot] [PATCH 7/9] at91rm9200: fix DCC support
In-Reply-To: <20090309111949.8FEBD832E8B8@gemini.denx.de>
References: <1236089265-24598-1-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-2-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-3-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-4-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-5-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-6-git-send-email-plagnioj@jcrosoft.com>
	<1236089265-24598-7-git-send-email-plagnioj@jcrosoft.com>
	<20090308233132.D8875832E8B8@gemini.denx.de>
	<20090309083649.GE24237@game.jcrosoft.org>
	<20090309111949.8FEBD832E8B8@gemini.denx.de>
Message-ID: <20090309111835.GJ24237@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 12:19 Mon 09 Mar     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <20090309083649.GE24237@game.jcrosoft.org> you wrote:
> >
> > > In message <1236089265-24598-7-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > > > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > > > ---
> > > >  cpu/arm920t/at91rm9200/interrupts.c |    2 ++
> > > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > > 
> > > Please explain which problem you are trying to fix.
> 
> ----^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
> 
> Which problem is there with the current code?
> 
> > > > +#if defined(CONFIG_DBGU) || defined(CONFIG_USART0) || defined(CONFIG_USART1)
> > > >  	/*shutdown the console to avoid strange chars during reset */
> > > >  	us->US_CR = (AT91C_US_RSTRX | AT91C_US_RSTTX);
> > > > +#endif
> > > 
> > > Why the #ifdef? Shutting down the console seems a good thing to me.
> > when using DCC we will not activate the at91 uart at all so we do not have to
> > shut it down
> 
> The #ifdef above does not seem to depend on DCC at all?
> 
> And what does it hurt if we always shut down the console? To me that
> looks clearer than an additional #ifdef.
> 
> Finally, what if somebody wants to use DCC and an UART simultaneously?
> I guess that should be possible, too.
It's not possible if you do not use the DCC multi support because the DCC will
replace the uart.

We must shutdown the console only if we use it which is not the case when we use
the DCC as principal serial

Best Regards,
J.