From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Mon, 9 Mar 2009 18:12:56 +0100 Subject: [U-Boot] [PATCH 7/9] at91rm9200: fix DCC support In-Reply-To: <20090309155049.9398B832E8B8@gemini.denx.de> References: <1236089265-24598-5-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-6-git-send-email-plagnioj@jcrosoft.com> <1236089265-24598-7-git-send-email-plagnioj@jcrosoft.com> <20090308233132.D8875832E8B8@gemini.denx.de> <20090309083649.GE24237@game.jcrosoft.org> <20090309111949.8FEBD832E8B8@gemini.denx.de> <20090309111835.GJ24237@game.jcrosoft.org> <20090309113743.5FC75832E8B8@gemini.denx.de> <20090309120954.GK24237@game.jcrosoft.org> <20090309155049.9398B832E8B8@gemini.denx.de> Message-ID: <20090309171256.GB20714@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 16:50 Mon 09 Mar , Wolfgang Denk wrote: > Dear Jean-Christophe PLAGNIOL-VILLARD, > > In message <20090309120954.GK24237@game.jcrosoft.org> you wrote: > > > > > > > The #ifdef above does not seem to depend on DCC at all? > > > > > > You did not answer this question. > > > > > > > > And what does it hurt if we always shut down the console? To me that > > > > > looks clearer than an additional #ifdef. > > the UART code is not active or compile so you can't do it. > > This statement makes no sense to me. If the #ifdef has any effect, > then this code is actually compiled. What would happen if the > statement would be executed? > > Actually this is a question I repeat in all my replies to your > posting - what exactly is the problem with the current code? Does it > cause crashes or so? Or is it just that you think it is not necessary > because UARTs are not active? It does not build because the serial driver of the rm9200 is not compiled this code must be use only if this driver is compile not everytime Best Regards, J.