From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Dooks Subject: Re: [PATCH 2/2] i2c: i2c-omap: Call request_irq with IRQF_DISABLED Date: Tue, 10 Mar 2009 00:52:22 +0000 Message-ID: <20090310005222.GE19758@fluff.org.uk> References: <7d7e7dd1a4c64c732a21bdfcf2bd42556be708c3.1236345858.git.Ext-Ari.Kauppi@nokia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <7d7e7dd1a4c64c732a21bdfcf2bd42556be708c3.1236345858.git.Ext-Ari.Kauppi-xNZwKgViW5gAvxtiuMwx3w@public.gmane.org> Sender: linux-i2c-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Ari Kauppi Cc: ben-linux-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-i2c@vger.kernel.org On Fri, Mar 06, 2009 at 03:34:54PM +0200, Ari Kauppi wrote: > I have observed some Spurious IRQ's for I2C1 when all kernel hacking options > (and thus LOCKDEP) are disabled. > > Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help > but IRQF_DISABLED is needed for proper behaviour. > > Signed-off-by: Ari Kauppi > Acked-by: Felipe Balbi > --- > drivers/i2c/busses/i2c-omap.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > index 0c3ed41..18af43f 100644 > --- a/drivers/i2c/busses/i2c-omap.c > +++ b/drivers/i2c/busses/i2c-omap.c > @@ -847,7 +847,7 @@ omap_i2c_probe(struct platform_device *pdev) > omap_i2c_init(dev); > > isr = (dev->rev < OMAP_I2C_REV_2) ? omap_i2c_rev1_isr : omap_i2c_isr; > - r = request_irq(dev->irq, isr, 0, pdev->name, dev); > + r = request_irq(dev->irq, isr, IRQF_DISABLED, pdev->name, dev); Is disabling all IRQs on the system the right thing to do? > if (r) { > dev_err(dev->dev, "failure requesting irq %i\n", dev->irq); > -- > 1.5.6.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben (ben-elnMNo+KYs3YtjvyW6yDsg@public.gmane.org, http://www.fluff.org/) 'a smiley only costs 4 bytes'