From: Balbir Singh <balbir@linux.vnet.ibm.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Cc: "linux-mm@kvack.org" <linux-mm@kvack.org>,
"nishimura@mxp.nes.nec.co.jp" <nishimura@mxp.nes.nec.co.jp>,
"kosaki.motohiro@jp.fujitsu.com" <kosaki.motohiro@jp.fujitsu.com>
Subject: Re: [RFC][PATCH 1/4] memcg: add softlimit interface and utilitiy function.
Date: Tue, 10 Mar 2009 13:33:23 +0530 [thread overview]
Message-ID: <20090310080323.GA26837@balbir.in.ibm.com> (raw)
In-Reply-To: <20090310145334.0473c3fe.kamezawa.hiroyu@jp.fujitsu.com>
* KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-03-10 14:53:34]:
> On Mon, 9 Mar 2009 14:18:44 +0530
> Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
>
> > * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-03-09 16:55:07]:
> >
> > > On Mon, 9 Mar 2009 13:14:49 +0530
> > > Balbir Singh <balbir@linux.vnet.ibm.com> wrote:
> > >
> > > > * KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com> [2009-03-09 16:39:07]:
> > > Hmm, them, moving mem->softlimit to res->softlimit is ok ?
> > >
> > > If no more "branch" to res_counter_charge/uncharge(), moving this to
> > > res_counter is ok to me.
> > >
> >
> > There is a branch, but the additional excessive checks are gone.
> > It should be possible to reduce the overhead to comparisons though.
> >
>
> I'm now rewriting to use res_counter but do you have any good reason to
> irq-off in res_counter ?
> It seems there are no callers in irq path.
It has been on my TODO list to make resource counter more efficient.
The reason for irq disabling is because counters routines can get called from
reclaim with irq's disabled as well.
--
Balbir
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2009-03-10 8:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-09 7:37 [RFC][PATCH] memcg: softlimit (Another one) v3 KAMEZAWA Hiroyuki
2009-03-09 7:39 ` [RFC][PATCH 1/4] memcg: add softlimit interface and utilitiy function KAMEZAWA Hiroyuki
2009-03-09 7:44 ` Balbir Singh
2009-03-09 7:55 ` KAMEZAWA Hiroyuki
2009-03-09 8:48 ` Balbir Singh
2009-03-10 5:53 ` KAMEZAWA Hiroyuki
2009-03-10 8:03 ` Balbir Singh [this message]
2009-03-10 8:31 ` Balbir Singh
2009-03-09 8:29 ` KAMEZAWA Hiroyuki
2009-03-09 8:54 ` Balbir Singh
2009-03-09 9:07 ` KAMEZAWA Hiroyuki
2009-03-09 7:41 ` [RFC][PATCH 2/4] memcg: softlimit priority and victim scheduler KAMEZAWA Hiroyuki
2009-03-09 7:42 ` [RFC][PATCH 3/4] memcg: softlimit caller via kswapd KAMEZAWA Hiroyuki
2009-03-10 19:02 ` Balbir Singh
2009-03-10 23:52 ` KAMEZAWA Hiroyuki
2009-03-12 0:05 ` KOSAKI Motohiro
2009-03-12 0:08 ` KAMEZAWA Hiroyuki
2009-03-09 7:43 ` [RFC][PATCH 4/4] memcg: softlimit documenation KAMEZAWA Hiroyuki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090310080323.GA26837@balbir.in.ibm.com \
--to=balbir@linux.vnet.ibm.com \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=kosaki.motohiro@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=nishimura@mxp.nes.nec.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.