Re: [PATCH] dnet: Dave DNET ethernet controller driver

From: Stephen Hemminger <shemminger@vyatta.com>
To: Ilya Yanok <yanok@emcraft.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk, netdev@vger.kernel.org,
	s.hauer@pengutronix.de, wd@denx.de, dzu@denx.de,
	Ilya Yanok <yanok@emcraft.com>
Subject: Re: [PATCH] dnet: Dave DNET ethernet controller driver
Date: Tue, 10 Mar 2009 21:18:41 -0700	[thread overview]
Message-ID: <20090310211841.388619ca@nehalam> (raw)
In-Reply-To: <1236738549-16703-1-git-send-email-yanok@emcraft.com>

On Wed, 11 Mar 2009 05:29:09 +0300
Ilya Yanok <yanok@emcraft.com> wrote:

> +static char ethaddr[18];
> +
> +module_param_string(ethaddr, ethaddr, sizeof(ethaddr), 0);
> +
> +static void get_mac_addr(struct net_device *nd, unsigned char *pmac)
> +{
> +	int i;
> +	char *p = ethaddr;
> +
> +	ethaddr[17] = 0;
> +	for (i = 0; i < ETH_ALEN; i++, p++) {
> +		pmac[i] = simple_strtoul(p, &p, 16);
> +		if (*p != ':')
> +			break;
> +	}
> +	if (i != ETH_ALEN - 1) {
> +		pr_err("Wrong MAC address format!\n");
> +		memset(pmac, 0, ETH_ALEN);
> +	}
> +}
> +

Do you still need this? Only works with one board, configuration via
module parameters is discouraged.  Same effect can be done by setting
mac address with regular tools.