From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from metis.ext.pengutronix.de ([92.198.50.35]:60700 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752463AbZCKKUL (ORCPT ); Wed, 11 Mar 2009 06:20:11 -0400 Date: Wed, 11 Mar 2009 11:20:09 +0100 From: Sascha Hauer To: Hans Verkuil Cc: linux-media@vger.kernel.org, Guennadi Liakhovetski Subject: Re: [PATCH 4/4] mt9v022: allow setting of bus width from board code Message-ID: <20090311102009.GZ425@pengutronix.de> References: <12860.62.70.2.252.1236766618.squirrel@webmail.xs4all.nl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <12860.62.70.2.252.1236766618.squirrel@webmail.xs4all.nl> Sender: linux-media-owner@vger.kernel.org List-ID: On Wed, Mar 11, 2009 at 11:16:58AM +0100, Hans Verkuil wrote: > > > This patch removes the phytec specific setting of the bus width > > and switches to the more generic query_bus_param/set_bus_param > > hooks > > > > Signed-off-by: Sascha Hauer > > --- > > drivers/media/video/Kconfig | 7 --- > > drivers/media/video/mt9v022.c | 97 > > +++++------------------------------------ > > 2 files changed, 11 insertions(+), 93 deletions(-) > > > > diff --git a/drivers/media/video/Kconfig b/drivers/media/video/Kconfig > > index 5fc1531..071d66f 100644 > > --- a/drivers/media/video/Kconfig > > +++ b/drivers/media/video/Kconfig > > @@ -729,6 +664,7 @@ static int mt9v022_video_probe(struct > > soc_camera_device *icd) > > /* Set monochrome or colour sensor type */ > > if (sensor_type && (!strcmp("colour", sensor_type) || > > !strcmp("color", sensor_type))) { > > + if (1) { > > ret = reg_write(icd, MT9V022_PIXEL_OPERATION_MODE, 4 | 0x11); > > mt9v022->model = V4L2_IDENT_MT9V022IX7ATC; > > icd->formats = mt9v022_colour_formats; > > 'if (1) {': some left-over debugging? oops, yes. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |