From: Ralf Baechle <ralf@linux-mips.org>
To: Manuel Lauss <mano@roarinelk.homelinux.net>
Cc: linux-mips@linux-mips.org, Thomas Gleixner <tglx@linutronix.de>
Subject: Re: __do_IRQ() going away
Date: Thu, 12 Mar 2009 10:28:10 +0100 [thread overview]
Message-ID: <20090312092810.GA13674@linux-mips.org> (raw)
In-Reply-To: <20090312072618.GA31978@roarinelk.homelinux.net>
On Thu, Mar 12, 2009 at 08:26:18AM +0100, Manuel Lauss wrote:
>
> On Wed, Mar 11, 2009 at 12:28:06PM +0100, Ralf Baechle wrote:
> > __do_IRQ() is deprecated since a long time and there are plans to remove
> > it for 2.6.30. The MIPS platforms seem to fall into three classes:
>
> > o Platforms that still seem to rely on __do_IRQ():
> > o All Alchemy platforms:
> > db1000_defconfig, db1100_defconfig, db1200_defconfig, db1500_defconfig,
> > db1550_defconfig, mtx1_defconfig, pb1100_defconfig, pb1500_defconfig
> > and pb1550_defconfig
>
> I believe that the defconfigs just need to be updated. There are no
> __do_IRQ invocations in the alchemy/ tree anymore, and generic hardirqs are
> enabled by CONFIG_SOC_AU1X00.
__do_IRQ will be called from the generic code if irq_desc->handle_irq is
not set for an interrupt and handle_irq will be left NULL if a platform
only calls set_irq_chip or even does a homebrew initialization. Fix is
to call set_irq_chip_and_handler or better set_irq_chip_and_handler_name.
Iow, now with CONFIG_GENERIC_HARDIRQS_NO__DO_IRQ always set half the
platforms will blow up because the function pointer irq_desc->handle_irq
is unset.
Ralf
next prev parent reply other threads:[~2009-03-12 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-11 11:28 __do_IRQ() going away Ralf Baechle
2009-03-11 23:23 ` Markus Gothe
2009-03-12 7:26 ` Manuel Lauss
2009-03-12 9:28 ` Ralf Baechle [this message]
2009-03-12 9:46 ` Manuel Lauss
2009-03-12 11:20 ` Ralf Baechle
2009-03-13 15:31 ` MIPS: EMMA2RH: Use handle_edge_irq() handler for GPIO interrupts Shinya Kuribayashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312092810.GA13674@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-mips@linux-mips.org \
--cc=mano@roarinelk.homelinux.net \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.