From: Mark Brown <broonie@sirena.org.uk>
To: "Lopez Cruz, Misael" <x0052729@ti.com>
Cc: "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>
Subject: Re: sys/class entry not created for jack in machine driver
Date: Thu, 12 Mar 2009 14:39:31 +0000 [thread overview]
Message-ID: <20090312143930.GC24376@sirena.org.uk> (raw)
In-Reply-To: <2C7D3DF36ADFFC479B44490D912B616705ECEA5E07@dlee07.ent.ti.com>
On Thu, Mar 12, 2009 at 04:54:16AM -0500, Lopez Cruz, Misael wrote:
> case of jacks not belonging to a codec, they never get registered. A jack
> device in a codec driver gets registered because codec when initializing
> the SoC card (snd_soc_init_card) registers the sound card, and the sound
> card registers all sound devices added to it, among them the jack device.
Ah, you should move the jack registration to the device initialisation -
it needs to happen before the card is registered. Putting it in
sdp4030_twl4030_init() ought to do the job.
> I'm registering the jack device after it's created (in function
> snd_jack_new) and now I get the sys/class entry for the headset jack in
> my machine driver. What do you think about that solution?
That shouldn't be required.
BTW, when talking about code modifications you've done it's normally
helpful if you post the change you've made to reduce the chances of
miscommunication.
prev parent reply other threads:[~2009-03-12 14:39 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 9:54 sys/class entry not created for jack in machine driver Lopez Cruz, Misael
2009-03-12 14:39 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090312143930.GC24376@sirena.org.uk \
--to=broonie@sirena.org.uk \
--cc=alsa-devel@alsa-project.org \
--cc=x0052729@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.