All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arthur Jones <ajones@riverbed.com>
To: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Cc: <e1000-devel@lists.sourceforge.net>, <netdev@vger.kernel.org>
Subject: [PATCH] igb: allow tx of pre-formatted vlan tagged packets
Date: Thu, 12 Mar 2009 13:27:24 -0700	[thread overview]
Message-ID: <20090312202724.GA9876@ajones-laptop.nbttech.com> (raw)

When the 82575 is fed 802.1q packets, it chokes with
an error of the form:

igb 0000:08:00.1: partial checksum but proto=81

As the logic there was not smart enough to look into
the vlan header to pick out the encapsulated protocol.

There are times when we'd like to send these packets
out without having to configure a vlan on the interface.
Here we check for the vlan tag and allow the packet to
go out with the correct hardware checksum.

Thanks to Kand Ly <kand@riverbed.com> for discovering the
issue and the coming up with a solution.  This patch is
based upon his work.

Signed-off-by: Arthur Jones <ajones@riverbed.com>
---
 drivers/net/igb/igb_main.c |   12 +++++++++++-
 1 files changed, 11 insertions(+), 1 deletions(-)

diff --git a/drivers/net/igb/igb_main.c b/drivers/net/igb/igb_main.c
index fddeece..99ba3a5 100644
--- a/drivers/net/igb/igb_main.c
+++ b/drivers/net/igb/igb_main.c
@@ -2778,7 +2778,17 @@ static inline bool igb_tx_csum_adv(struct igb_adapter *adapter,
 		tu_cmd |= (E1000_TXD_CMD_DEXT | E1000_ADVTXD_DTYP_CTXT);
 
 		if (skb->ip_summed == CHECKSUM_PARTIAL) {
-			switch (skb->protocol) {
+			__be16 protocol;
+
+			if (skb->protocol == __constant_htons(ETH_P_8021Q)) {
+				const struct vlan_ethhdr *vhdr =
+					(const struct vlan_ethhdr *) skb->data;
+
+				protocol = vhdr->h_vlan_encapsulated_proto;
+			} else
+				protocol = skb->protocol;
+
+			switch (protocol) {
 			case __constant_htons(ETH_P_IP):
 				tu_cmd |= E1000_ADVTXD_TUCMD_IPV4;
 				if (ip_hdr(skb)->protocol == IPPROTO_TCP)
-- 
1.5.6.3

             reply	other threads:[~2009-03-12 20:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-12 20:27 Arthur Jones [this message]
2009-03-12 20:51 ` [PATCH] igb: allow tx of pre-formatted vlan tagged packets Stephen Hemminger
2009-03-12 21:00   ` Arthur Jones
2009-03-12 21:22     ` Stephen Hemminger
2009-03-12 21:33 ` [net-next PATCH] " Arthur Jones
2009-03-12 22:30   ` Alexander Duyck
2009-03-13 14:55     ` Arthur Jones
2009-03-13 16:24       ` Arthur Jones
2009-03-17 17:39   ` [net-next PATCH -- take 2] " Arthur Jones
2009-03-19  6:40     ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090312202724.GA9876@ajones-laptop.nbttech.com \
    --to=ajones@riverbed.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.