From mboxrd@z Thu Jan  1 00:00:00 1970
From: Samuel Thibault <samuel.thibault@ens-lyon.org>
Subject: Re: [PATCH] minios: allocate machine contiguous pages
Date: Fri, 13 Mar 2009 00:42:02 +0100
Message-ID: <20090312234202.GE4955@const.famille.thibault.fr>
References: <49B965FD.4050103@netronome.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Return-path: <xen-devel-bounces@lists.xensource.com>
Content-Disposition: inline
In-Reply-To: <49B965FD.4050103@netronome.com>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Rolf Neugebauer <rolf.neugebauer@netronome.com>
Cc: Xen-devel <xen-devel@lists.xensource.com>
List-Id: xen-devel@lists.xenproject.org

Rolf Neugebauer, le Thu 12 Mar 2009 19:43:57 +0000, a =E9crit :
> +#define MAX_CONTIG_ORDER 9 /* 2MB */
> +unsigned long alloc_contig_pages(int order, unsigned int addr_bits)
> +{
> +    unsigned long in_frames[1<<MAX_CONTIG_ORDER], out_frames, mfn;
> +    multicall_entry_t call[(1UL << MAX_CONTIG_ORDER)];

Mmm, can't we assume we have a C99 compiler that can just use order
instead of MAX_CONTIG_ORDER?

> +    /* set up arguments for exchange hyper call */
> +    set_xen_guest_handle(exchange.in.extent_start, in_frames);
> +	set_xen_guest_handle(exchange.out.extent_start, &out_frames);

There are mixed tabs and spaces here.

Samuel