All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <jens.axboe@oracle.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [GIT PATCH] block: cleanup patches
Date: Sun, 15 Mar 2009 17:45:26 +0100	[thread overview]
Message-ID: <20090315164526.GD27476@kernel.dk> (raw)
In-Reply-To: <49BB0FB7.2070109@kernel.org>

On Sat, Mar 14 2009, Tejun Heo wrote:
> Tejun Heo wrote:
> > Hello,
> > 
> > This patchset is available in the following git tree.
> > 
> >  git://git.kernel.org/pub/scm/linux/kernel/git/tj/misc.git block-cleanup
> > 
> > This patchset contains the following 14 cleanup patches.
> 
> Jens, once you're okay with the rest of the changes, I'll remove IDE
> related stuff and repost the patchset.

I only gave it a quick glance, looks mostly OK. Though I don't like
putting elv_ prefixed stuff in blk-core. I agree it belongs there
though, it's really block layer functionality and not io scheduler
interfacing. So rename it blk_ instead and put compatability names in
the header file instead.

I'll give it a more thorough review and integration test tomorrow.

-- 
Jens Axboe


  reply	other threads:[~2009-03-15 16:45 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-03-13  5:02 [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-13  5:02 ` [PATCH 01/14] block: merge blk_invoke_request_fn() into __blk_run_queue() Tejun Heo
2009-03-13  5:02 ` [PATCH 02/14] block: kill blk_start_queueing() Tejun Heo
2009-03-13  5:02 ` [PATCH 03/14] block: don't set REQ_NOMERGE unnecessarily Tejun Heo
2009-03-13  5:02 ` [PATCH 04/14] block: cleanup REQ_SOFTBARRIER usages Tejun Heo
2009-03-13  5:02 ` [PATCH 05/14] block: clean up misc stuff after block layer timeout conversion Tejun Heo
2009-03-13  5:02 ` [PATCH 06/14] block: reorder request completion functions Tejun Heo
2009-03-13  5:02 ` [PATCH 07/14] block: reorganize request fetching functions Tejun Heo
2009-03-13  5:02 ` [PATCH 08/14] block: kill blk_end_request_callback() Tejun Heo
2009-03-13  5:02 ` [PATCH 09/14] block: clean up request completion API Tejun Heo
2009-03-16  9:12   ` Boaz Harrosh
2009-03-16  9:45     ` Tejun Heo
2009-03-13  5:02 ` [PATCH 10/14] block: move rq->start_time initialization to blk_rq_init() Tejun Heo
2009-03-13  5:02 ` [PATCH 11/14] block: implement and use [__]blk_end_request_all() Tejun Heo
2009-03-13 19:21   ` Bartlomiej Zolnierkiewicz
2009-03-14  1:56     ` Tejun Heo
2009-03-14  2:10       ` Tejun Heo
2009-03-14 19:23       ` Bartlomiej Zolnierkiewicz
2009-03-14 19:56         ` James Bottomley
2009-03-14 20:19           ` Bartlomiej Zolnierkiewicz
2009-03-15 16:48             ` Jens Axboe
2009-03-15 17:40               ` Bartlomiej Zolnierkiewicz
2009-03-15 18:39                 ` Jens Axboe
2009-03-15 20:34                   ` Bartlomiej Zolnierkiewicz
2009-03-15 20:48                     ` Jens Axboe
2009-03-15 21:34                       ` Bartlomiej Zolnierkiewicz
2009-03-16  1:39                         ` Tejun Heo
2009-03-13  5:02 ` [PATCH 12/14] block: kill end_request() Tejun Heo
2009-03-13  5:02 ` [PATCH 13/14] ubd: simplify block request completion Tejun Heo
2009-03-13  5:02 ` [PATCH 14/14] block: clean up unnecessary stuff from block drivers Tejun Heo
2009-03-14  2:00 ` [GIT PATCH] block: cleanup patches Tejun Heo
2009-03-15 16:45   ` Jens Axboe [this message]
2009-03-16  1:15     ` Tejun Heo
2009-03-16  7:22       ` Jens Axboe
2009-03-16  7:53         ` Tejun Heo
2009-03-16  7:57           ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090315164526.GD27476@kernel.dk \
    --to=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.