From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Mon, 23 Mar 2009 23:09:48 +0100 Subject: [U-Boot] [PATCH 1/2] Fix OneNAND ipl to read CONFIG_SYS_MONITOR_LEN In-Reply-To: <20090323212514.GA30976@ld0162-tx32.am.freescale.net> References: <20090323212514.GA30976@ld0162-tx32.am.freescale.net> Message-ID: <20090323220948.DCC74832E406@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Scott Wood, In message <20090323212514.GA30976@ld0162-tx32.am.freescale.net> you wrote: > > > + /* Check for invalid block mark */ > > + if (page < 2 && (onenand_readw(ONENAND_SPARERAM) != 0xffff)) > > + return 1; > > Unnecessary parens. Where? I find them pretty useful. Please keep! Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de I don't want to be young again, I just don't want to get any older.