From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1LoeJd-00056r-IK
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 09:47:45 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1LoeJY-00054K-OV
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 09:47:45 -0400
Received: from [199.232.76.173] (port=45575 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1LoeJY-00054D-GL
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 09:47:40 -0400
Received: from mx20.gnu.org ([199.232.41.8]:28539)
	by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32)
	(Exim 4.60) (envelope-from <paul@codesourcery.com>)
	id 1LoeJY-0007ry-5n
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 09:47:40 -0400
Received: from mail.codesourcery.com ([65.74.133.4])
	by mx20.gnu.org with esmtp (Exim 4.60)
	(envelope-from <paul@codesourcery.com>) id 1LoeJV-0006uc-PJ
	for qemu-devel@nongnu.org; Tue, 31 Mar 2009 09:47:38 -0400
From: Paul Brook <paul@codesourcery.com>
Subject: Re: [Qemu-devel] [PATCH] Document Qemu coding style
Date: Tue, 31 Mar 2009 13:47:34 +0000
References: <1238361823-24939-1-git-send-email-avi@redhat.com>
In-Reply-To: <1238361823-24939-1-git-send-email-avi@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200903311447.34603.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: Avi Kivity <avi@redhat.com>

> +2. Line width
> +
> +Lines are 80 characters wide plus some slop.  Try to fit your code into
> +eighty characters, but if it makes a snippet particularly ugly, allow
> +yourself some slack.  Don't overdo it though.

I'd remove the "plus some slop". My guess is that most people using a 
non-graphical editor (and probably many of those using graphical variants of 
vi/emacs) still wrap at 80 characters. If you can't find a convenient place 
to break the line, then maybe you're doing something else wrong (e.g. using 
40-character variable names :-)

Other than that, looks ok.

Paul