Re: [RFC v14-rc2][PATCH 3/7] sysvipc-shm: checkpoint

From: "Serge E. Hallyn" <serue-r/Jw6+rmf7HQT0dZR+AlfA@public.gmane.org>
To: Oren Laadan <orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>
Cc: containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	Dave Hansen
	<dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org>
Subject: Re: [RFC v14-rc2][PATCH 3/7] sysvipc-shm: checkpoint
Date: Tue, 31 Mar 2009 15:06:58 -0500	[thread overview]
Message-ID: <20090331200658.GA19038@us.ibm.com> (raw)
In-Reply-To: <1238477552-17083-4-git-send-email-orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org>

Quoting Oren Laadan (orenl-eQaUEPhvms7ENvBUuze7eA@public.gmane.org):
...
>  int cr_write_ipc(struct cr_ctx *ctx, struct nsproxy *nsproxy)
>  {
> -	return 0;
> +	return cr_write_ipc_shm(ctx, nsproxy->ipc_ns);
>  }

What is the plan for implementing support for nested ipc namespaces,
since all ipc data is currently stored as a single global checkpoint
property before the task data?

Are you figuring you'll just do cr_write_ipc_shm() for all nsproxies
which are part of the checkpoint image, and store an ipc_ns id
or nsproxy id alongside it, so that at restart you just recreate all
the ipc namespaces ahead of time, then attach the tasks to their
target namespaces as they are created?

Just wondering...  as it stands the code looks more like it *wants*
to be targeted at only one ipcns per checkpoint image.

-serge