From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
Date: Thu, 2 Apr 2009 21:27:55 +0200
Subject: [U-Boot] [RFC PATCH V2] drivers/usb: regorganisation
In-Reply-To: <20090402180707.A103583797DC@gemini.denx.de>
References: <3efb10970904020826n27ff276fvb4da337b7a5c04b9@mail.gmail.com>
	<1238691332-27548-1-git-send-email-plagnioj@jcrosoft.com>
	<20090402180707.A103583797DC@gemini.denx.de>
Message-ID: <20090402192755.GB15621@game.jcrosoft.org>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On 20:07 Thu 02 Apr     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1238691332-27548-1-git-send-email-plagnioj@jcrosoft.com> you wrote:
> > move to linux usb driver organisation
> > 
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> > Cc: Remy Bohmer <linux@bohmer.net>
> > ---
> > Remy is this one ok for you?
> 
> Looks OK to me, but..
> 
> 
> > diff --git a/drivers/serial/usbtty.c b/drivers/serial/usbtty.c
> > index d8b1387..71f0e5b 100644
> > --- a/drivers/serial/usbtty.c
> > +++ b/drivers/serial/usbtty.c
> > @@ -94,7 +94,7 @@ static char serial_number[16];
> >   * Descriptors, Strings, Local variables.
> >   */
> >  
> > -/* defined and used by usbdcore_ep0.c */
> > +/* defined and used by ep0.c */
> >  extern struct usb_string_descriptor **usb_strings;
> 
> This is now too short. Where might ep0.c be? Please use "gadget/ep0.c"
> here.
ok
> 
> 
> > rename to drivers/usb/gadget/mpc8xx_udc.c
> > index 0e311ad..8d7bd65 100644
> > --- a/drivers/usb/usbdcore_mpc8xx.c
> > +++ b/drivers/usb/gadget/mpc8xx_udc.c
> > @@ -3,7 +3,7 @@
> >   * bodonoghue at CodeHermit.ie
> >   *
> >   * References
> > - * DasUBoot/drivers/usb/usbdcore_omap1510.c, for design and implementation
> > + * DasUBoot/drivers/usb/omap1510_udc.c, for design and implementation
> 
> Please change into "drivers/usb/omap1510_udc.c"
drivers/usb/gadget/omap1510_udc.c
ok

if Remy is ok
could apply the at91 pull request then I will generate the final usb
reorganisation patch?

Best Regards,
J.