From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 3/9] bio-cgroup controller Date: Thu, 16 Apr 2009 17:44:28 -0700 Message-ID: <20090416174428.6bb5da21.akpm@linux-foundation.org> References: <1239740480-28125-1-git-send-email-righi.andrea@gmail.com> <1239740480-28125-4-git-send-email-righi.andrea@gmail.com> <20090416152937.b2188370.akpm@linux-foundation.org> <20090417092040.1c832c69.kamezawa.hiroyu@jp.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20090417092040.1c832c69.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: containers-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: KAMEZAWA Hiroyuki Cc: randy.dunlap-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org, menage-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org, chlunde-om2ZC0WAoZIXWF+eFR7m5Q@public.gmane.org, eric.rannaud-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, balbir-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, fernando-gVGce1chcLdL9jVzuh4AOg@public.gmane.org, Andrea Righi , dradford-cT2on/YLNlBWk0Htik3J/w@public.gmane.org, agk-9JcytcrH/bA+uJoB2kUjGw@public.gmane.org, subrata-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, axboe-tSWWG44O7X1aa/9Udqfwiw@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, dave-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, matt-cT2on/YLNlBWk0Htik3J/w@public.gmane.org, roberto-5KDOxZqKugI@public.gmane.org, ngupta-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org List-Id: containers.vger.kernel.org On Fri, 17 Apr 2009 09:20:40 +0900 KAMEZAWA Hiroyuki wrote: > On Thu, 16 Apr 2009 15:29:37 -0700 > Andrew Morton wrote: > > > On Tue, 14 Apr 2009 22:21:14 +0200 > > Andrea Righi wrote: > > > > > Subject: [PATCH 3/9] bio-cgroup controller > > > > Sorry, but I have to register extreme distress at the name of this. > > The term "bio" is well-established in the kernel and here we have a new > > definition for the same term: "block I/O". > > > > "bio" was a fine term for you to have chosen from the user's > > perspective, but from the kernel developer perspective it is quite > > horrid. The patch adds a vast number of new symbols all into the > > existing "bio_" namespace, many of which aren't related to `struct bio' > > at all. > > > > At least, I think that's what's happening. Perhaps the controller > > really _is_ designed to track `struct bio'? If so, that's an odd thing > > to tell userspace about. > > > Hmm, how about iotrack-cgroup ? > Well. blockio_cgroup has the same character count and is more specific. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760013AbZDQBBT (ORCPT ); Thu, 16 Apr 2009 21:01:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754912AbZDQBBA (ORCPT ); Thu, 16 Apr 2009 21:01:00 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:37214 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754540AbZDQBBA (ORCPT ); Thu, 16 Apr 2009 21:01:00 -0400 Date: Thu, 16 Apr 2009 17:44:28 -0700 From: Andrew Morton To: KAMEZAWA Hiroyuki Cc: Andrea Righi , menage@google.com, balbir@linux.vnet.ibm.com, guijianfeng@cn.fujitsu.com, agk@sourceware.org, axboe@kernel.dk, baramsori72@gmail.com, chlunde@ping.uio.no, dave@linux.vnet.ibm.com, dpshah@google.com, eric.rannaud@gmail.com, fernando@oss.ntt.co.jp, taka@valinux.co.jp, lizf@cn.fujitsu.com, matt@bluehost.com, dradford@bluehost.com, ngupta@google.com, randy.dunlap@oracle.com, roberto@unbit.it, ryov@valinux.co.jp, s-uchida@ap.jp.nec.com, subrata@linux.vnet.ibm.com, yoshikawa.takuya@oss.ntt.co.jp, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/9] bio-cgroup controller Message-Id: <20090416174428.6bb5da21.akpm@linux-foundation.org> In-Reply-To: <20090417092040.1c832c69.kamezawa.hiroyu@jp.fujitsu.com> References: <1239740480-28125-1-git-send-email-righi.andrea@gmail.com> <1239740480-28125-4-git-send-email-righi.andrea@gmail.com> <20090416152937.b2188370.akpm@linux-foundation.org> <20090417092040.1c832c69.kamezawa.hiroyu@jp.fujitsu.com> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Apr 2009 09:20:40 +0900 KAMEZAWA Hiroyuki wrote: > On Thu, 16 Apr 2009 15:29:37 -0700 > Andrew Morton wrote: > > > On Tue, 14 Apr 2009 22:21:14 +0200 > > Andrea Righi wrote: > > > > > Subject: [PATCH 3/9] bio-cgroup controller > > > > Sorry, but I have to register extreme distress at the name of this. > > The term "bio" is well-established in the kernel and here we have a new > > definition for the same term: "block I/O". > > > > "bio" was a fine term for you to have chosen from the user's > > perspective, but from the kernel developer perspective it is quite > > horrid. The patch adds a vast number of new symbols all into the > > existing "bio_" namespace, many of which aren't related to `struct bio' > > at all. > > > > At least, I think that's what's happening. Perhaps the controller > > really _is_ designed to track `struct bio'? If so, that's an odd thing > > to tell userspace about. > > > Hmm, how about iotrack-cgroup ? > Well. blockio_cgroup has the same character count and is more specific.