From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Christophe PLAGNIOL-VILLARD Date: Fri, 17 Apr 2009 09:36:10 +0200 Subject: [U-Boot] [PATCH v4] Marvell MV88E61XX Switch Driver support In-Reply-To: <1239801881-21816-1-git-send-email-prafulla@marvell.com> References: <1239801881-21816-1-git-send-email-prafulla@marvell.com> Message-ID: <20090417073610.GB26651@game.jcrosoft.org> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de On 18:54 Wed 15 Apr , Prafulla Wadaskar wrote: > Chips supported:- > 1. 88E6161 6 port gbe swtich with 5 integrated PHYs > 2. 88E6165 6 port gbe swtich with 5 integrated PHYs > 2. 88E6132 3 port gbe swtich with 2 integrated PHYs > Platform specific configuration supported > > Note: This driver is supported and tested against > kirkwood egiga interface > > Contributors: > Yotam Admon > Michael Blostein > Reviewed by: Ronen Shitrit > Signed-off-by: Prafulla Wadaskar > --- > Changelog:- > v2: updated as per review comments for v1 > removed other two drivers form earlier patch > debug_prints removed > driver moved to drivers/net/ > > v3: updated as per review comments for v2 > miiphy interface used, platform specific dependency resolved > Chip id detection and printing added > common code forked out > some cosmetic and magic number fixes > > v4: updated as per review comments for v3 > mv88e61xx.h added > platform specific configuration support added > some more documentation references provided > cleaned rgmii delay enable related code this version looks better I've just 2 comments on it 1) drivers/net/phy/ is for phylib and drivers as a switch can be consider as a multiple phy port please move it there 2) the Vlan init is not so clear for people who need to maintain or update the code as the Marvell's switch datasheets are all under NDA Best Regards, J.