All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Snitzer <snitzer@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Subject: Re: [PATCH 2/4] multipath-tools: install libmultipath.so in $syslibdir
Date: Sun, 19 Apr 2009 18:36:20 -0400	[thread overview]
Message-ID: <20090419223620.GA9385@redhat.com> (raw)
In-Reply-To: <1240179025.25083.2.camel@plop>

On Sun, Apr 19 2009 at  6:10pm -0400,
Christophe Varoqui <christophe.varoqui@free.fr> wrote:

> Le vendredi 17 avril 2009 à 18:07 -0400, Mike Snitzer a écrit :
> > Allows libmultipath.so to be installed in the proper lib dir
> > (e.g. /lib64).  $libdir is already used for /lib/multipath
> > 
> 
> Mike,
> am I missing something ... I don't the lib/lib64 switching code.

The standard install would still just place libmultipath.so in /lib but
this patch exposes the ability to override the default e.g.:
make install syslibdir=/lib64 libdir=/lib64/multipath

The path checker and prioritizer modules would get installed in
/lib64/multipath and libmultipath.so in /lib64


> > ---
> >  Makefile.inc          |    1 +
> >  libmultipath/Makefile |    6 +++---
> >  2 files changed, 4 insertions(+), 3 deletions(-)
> > 
> > diff --git a/Makefile.inc b/Makefile.inc
> > index 3e5bca0..1fe9782 100644
> > --- a/Makefile.inc
> > +++ b/Makefile.inc
> > @@ -21,6 +21,7 @@ multipathdir = $(TOPDIR)/libmultipath
> >  mandir      = $(prefix)/usr/share/man/man8
> >  man5dir     = $(prefix)/usr/share/man/man5
> >  rcdir	    = $(prefix)/etc/init.d
> > +syslibdir   = $(prefix)/lib
> >  libdir	    = $(prefix)/lib/multipath
> >  
> >  GZIP        = /bin/gzip -9 -c
> > diff --git a/libmultipath/Makefile b/libmultipath/Makefile
> > index 35cb911..503223d 100644
> > --- a/libmultipath/Makefile
> > +++ b/libmultipath/Makefile
> > @@ -26,12 +26,12 @@ $(LIBS): $(OBJS)
> >  	$(CC) $(SHARED_FLAGS) -Wl,-soname,$@ $(CFLAGS) -o $@ $(OBJS)
> >  
> >  install:
> > -	$(INSTALL_PROGRAM) -d $(DESTDIR)$(prefix)/lib
> > -	$(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(prefix)/lib/$(LIBS)
> > +	$(INSTALL_PROGRAM) -d $(DESTDIR)$(syslibdir)
> > +	$(INSTALL_PROGRAM) -m 755 $(LIBS) $(DESTDIR)$(syslibdir)/$(LIBS)
> >  	$(INSTALL_PROGRAM) -m 755 -d $(DESTDIR)$(libdir)
> >  
> >  uninstall:
> > -	rm -f $(DESTDIR)$(prefix)/lib/$(LIBS)
> > +	rm -f $(DESTDIR)$(syslibdir)/$(LIBS)
> >  
> >  clean:
> >  	rm -f core *.a *.o *.gz *.so
> 
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel

  reply	other threads:[~2009-04-19 22:36 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-17 22:07 [PATCH 0/4] Various small multipath-tools improvements Mike Snitzer
2009-04-17 22:07 ` [PATCH 1/4] multipath-tools: update scsi_id arguments Mike Snitzer
2009-04-17 22:07 ` [PATCH 2/4] multipath-tools: install libmultipath.so in $syslibdir Mike Snitzer
2009-04-19 22:10   ` Christophe Varoqui
2009-04-19 22:36     ` Mike Snitzer [this message]
2009-04-22 20:44       ` Christophe Varoqui
2009-04-17 22:07 ` [PATCH 3/4] multipath-tools: update multipathd.init.redhat Mike Snitzer
2009-04-17 22:08 ` [PATCH 4/4] multipath-tools: change default location for bindings file Mike Snitzer
2009-04-18 17:41 ` [PATCH 0/4] Various small multipath-tools improvements christophe.varoqui
2009-04-18 17:53   ` Mike Snitzer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090419223620.GA9385@redhat.com \
    --to=snitzer@redhat.com \
    --cc=dm-devel@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.