All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Li Zefan <lizf@cn.fujitsu.com>
Cc: Tom Zanussi <tzanussi@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Frederic Weisbecker <fweisbec@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] tracing/filters: disallow newline as delimeter
Date: Tue, 21 Apr 2009 11:57:05 +0200	[thread overview]
Message-ID: <20090421095705.GA15448@elte.hu> (raw)
In-Reply-To: <49ED8DFD.9070909@cn.fujitsu.com>


* Li Zefan <lizf@cn.fujitsu.com> wrote:

> I guess because user input is often ended with '\n' (like "echo 
> xxx"), thus '\n' is used as a delimeter besides ' ', but we can 
> just strip tailing spaces.

Hm, how about:

( echo 'x'
  echo '|| y' ) > filter

type of scripts? Shouldnt the parser be permissive in general?

	Ingo

  reply	other threads:[~2009-04-21  9:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-21  9:11 [PATCH 1/3] tracing/filters: don't remove old filters when failed to write subsys->filter Li Zefan
2009-04-21  9:12 ` [PATCH 2/3] tracing/filters: allow user-input to be integer-like string Li Zefan
2009-04-21 10:08   ` [tip:tracing/core] " tip-bot for Li Zefan
2009-04-21  9:12 ` [PATCH 3/3] tracing/filters: disallow newline as delimeter Li Zefan
2009-04-21  9:57   ` Ingo Molnar [this message]
2009-04-21 10:06     ` Li Zefan
2009-04-21 10:07       ` Ingo Molnar
2009-04-21 10:14         ` Li Zefan
2009-04-21 10:16           ` Ingo Molnar
2009-04-22  5:21             ` Tom Zanussi
2009-04-22  8:09               ` Ingo Molnar
2009-04-23  5:18                 ` Tom Zanussi
2009-04-21 10:08 ` [tip:tracing/core] tracing/filters: don't remove old filters when failed to write subsys->filter tip-bot for Li Zefan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090421095705.GA15448@elte.hu \
    --to=mingo@elte.hu \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=rostedt@goodmis.org \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.