From: Sascha Hauer <s.hauer@pengutronix.de>
To: Ivo Clarysse <ivo.clarysse@gmail.com>
Cc: netdev@vger.kernel.org, Lennert Buytenhek <kernel@wantstofly.org>,
Gilles Chanteperdrix <gilles.chanteperdrix@xenomai.org>
Subject: Re: [PATCH 1/2] Add an alternative cs89x0 driver
Date: Wed, 22 Apr 2009 14:18:21 +0200 [thread overview]
Message-ID: <20090422121821.GI21747@pengutronix.de> (raw)
In-Reply-To: <ba216b430904220228o369d0a5eg79c876733dcc7c8c@mail.gmail.com>
On Wed, Apr 22, 2009 at 11:28:17AM +0200, Ivo Clarysse wrote:
> On Wed, Apr 22, 2009 at 9:59 AM, Sascha Hauer <s.hauer@pengutronix.de> wrote:
>
> > +#define CS8900A 0x0000
> > +#define REV_B 7
> > +#define REV_C 8
> > +#define REV_D 9
>
> These REV_B / REV_C / REV_D defines are not used, and in fact depend
> on the cs89x0x variant.
>
> > + dev_info(&pdev->dev, "CS8900A rev %c detected\n",
> > + 'B' + REVISION(value) - REV_B);
>
> This will report incorrectly for CS8900 (not CS8900A), and for CS8900A rev. F:
Ok, will fix.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2009-04-22 12:18 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-22 7:59 [PATCH] Add new cs89x0 driver Sascha Hauer
2009-04-22 7:59 ` [PATCH 1/2] Add an alternative " Sascha Hauer
2009-04-22 7:59 ` [PATCH 2/2] mx1ads: Add cs89x0 network support Sascha Hauer
2009-04-22 9:28 ` [PATCH 1/2] Add an alternative cs89x0 driver Ivo Clarysse
2009-04-22 12:18 ` Sascha Hauer [this message]
2009-04-22 9:42 ` Gilles Chanteperdrix
2009-04-22 12:20 ` Sascha Hauer
2009-04-22 12:25 ` Gilles Chanteperdrix
2009-04-22 13:05 ` Sascha Hauer
2009-08-26 10:46 ` Kurt Van Dijck
2009-09-07 10:24 ` Sascha Hauer
2009-09-07 12:35 ` Kurt Van Dijck
2009-09-07 13:21 ` Sascha Hauer
2009-10-16 9:37 ` Kurt Van Dijck
2009-04-22 22:53 ` [PATCH] Add new " Lennert Buytenhek
2009-04-23 7:03 ` Sascha Hauer
2009-10-20 9:55 ` Ben Dooks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090422121821.GI21747@pengutronix.de \
--to=s.hauer@pengutronix.de \
--cc=gilles.chanteperdrix@xenomai.org \
--cc=ivo.clarysse@gmail.com \
--cc=kernel@wantstofly.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.