All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: James Bottomley <James.Bottomley@HansenPartnership.com>,
	Matthew Dharm <mdharm-usb@one-eyed-alien.net>,
	SCSI development list <linux-scsi@vger.kernel.org>,
	USB Storage list <usb-storage@lists.one-eyed-alien.net>
Subject: Re: [PATCH] SCSI: add check_capacity flag and sd_read_last_sector()
Date: Wed, 22 Apr 2009 08:57:37 -0700	[thread overview]
Message-ID: <20090422155737.GA18880@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0904221034340.3405-100000@iolanthe.rowland.org>

On Wed, Apr 22, 2009 at 10:42:36AM -0400, Alan Stern wrote:
> This patch (as1196) adds a new scsi_device flag to tell sd.c that it
> should verify the results of READ CAPACITY by trying the read the last
> sector.  This is necessary because a large percentage of USB
> mass-storage devices -- too many for a blacklist -- have a bug whereby
> they return the total number of sectors rather than the index of the
> last sector.
> 
> The new sd_read_last_sector() routine carries out the test, using a
> very short timeout and a small number of retries.  Any working device
> for which the check_capacity flag is set should be able to pass the
> test easily.
> 
> Signed-off-by: Alan Stern <stern@rowland.harvard.edu>
> 
> ---
> 
> James & Greg:
> 
> Although part of this patch touches usb-storage, the majority of 
> it affects SCSI files.  Is it okay if the whole thing goes in via 
> James's tree?

No objection from me at all.  Feel free to add a:
	Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
to the patch and push it through James.

thanks,

greg k-h

  parent reply	other threads:[~2009-04-22 16:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-22 14:42 [PATCH] SCSI: add check_capacity flag and sd_read_last_sector() Alan Stern
2009-04-22 14:51 ` Matthew Wilcox
2009-04-22 17:17   ` Alan Stern
2009-04-22 15:57 ` Greg KH [this message]
2009-04-22 19:17 ` [usb-storage] " Andries E. Brouwer
2009-04-22 20:47   ` Alan Stern
2009-04-22 23:03     ` Andries E. Brouwer
2009-04-23  2:33       ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090422155737.GA18880@kroah.com \
    --to=greg@kroah.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mdharm-usb@one-eyed-alien.net \
    --cc=stern@rowland.harvard.edu \
    --cc=usb-storage@lists.one-eyed-alien.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.