Re: [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2 build

From: Andi Kleen <andi@firstfloor.org>
To: Arjan van de Ven <arjan@linux.intel.com>
Cc: Andi Kleen <andi@firstfloor.org>,
	Johannes Weiner <hannes@cmpxchg.org>,
	linux-kernel@vger.kernel.org, torvalds@osdl.org, akpm@osdl.org
Subject: Re: [PATCH] Eliminate thousands of warnings in WARN_ON with gcc 3.2 build
Date: Thu, 23 Apr 2009 17:23:23 +0200	[thread overview]
Message-ID: <20090423152323.GQ13896@one.firstfloor.org> (raw)
In-Reply-To: <49F08447.9040003@linux.intel.com>

On Thu, Apr 23, 2009 at 08:07:51AM -0700, Arjan van de Ven wrote:
> Andi Kleen wrote:
> >On Thu, Apr 23, 2009 at 04:38:59PM +0200, Johannes Weiner wrote:
> >>>+void warn_slowpath_null(const char *file, int line)
> >>>+{
> >>>+	warn_slowpath_fmt(file, line, (const char *) { 0 });
> >>>+}
> >>>+EXPORT_SYMBOL(warn_slowpath_null);
> >>I would WTF here without knowing the warning.  Can you add a comment?
> >>
> >>Otherwise, Acked-by: Johannes Weiner <hannes@cmpxchg.org>
> >
> >Ok version with comment.
> 
> Makes sense if we plan to keep gcc 3.2 supported; if we plan to drop it 
> then we shouldn't bother.

It helps even for other compilers for code size, at least it shrunk Johannes' 
kernel by about 3k

> Acked-by: Arjan van de Ven <arjan@linux.intel.com>

Thanks.

-Andi

-- 
ak@linux.intel.com -- Speaking for myself only.