All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: vapier.adi@gmail.com, Atsushi Nemoto <anemo@mba.ocn.ne.jp>,
	akpm@linux-foundation.org, linux-kernel@vger.kernel.org,
	hcegtvedt@atmel.com, vapier@gentoo.org,
	rongkai.zhan@windriver.com, balajirrao@openmoko.org,
	david-b@pacbell.net, broonie@opensource.wolfsonmicro.com
Subject: Re: [rtc-linux] Re: [PATCH] rtc: Make rtc_update_irq callable with irqs enabled
Date: Thu, 23 Apr 2009 18:40:24 +0200	[thread overview]
Message-ID: <20090423184024.39402a8f@i1501.lan.towertech.it> (raw)
In-Reply-To: <8bd0f97a0904230930w7c9ffaa4x5110c59098ff475b@mail.gmail.com>

On Thu, 23 Apr 2009 12:30:58 -0400
Mike Frysinger <vapier.adi@gmail.com> wrote:

>   for the blackfin you should just check if
> >  you have locking issues in your irq routine  
> 
> the Blackfin driver calls rtc_update_irq() from its IRQ handler and
> the handler is not registered with IRQF_DISABLED.  it makes more sense
> to me to fix rtc_update_irq() than require all RTC drivers to register
> with IRQF_DISABLED.  especially in my case as the Blackfin driver
> itself doesnt need any locks.

 I agree. rtc_update_irq is not problematic by itself, it just takes
 locks that other parts of the driver should take appropriately.

 For example, if you take irq_lock with irqs enabled you
 will get in trouble. blackfin seems ok, for the other
 drivers we need to verify this.

-- 

 Best regards,

 Alessandro Zummo,
  Tower Technologies - Torino, Italy

  http://www.towertech.it


      reply	other threads:[~2009-04-23 16:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-06 16:50 [PATCH] rtc: Make rtc_update_irq callable with irqs enabled Atsushi Nemoto
2009-04-09 22:39 ` Andrew Morton
2009-04-09 22:58   ` Alessandro Zummo
2009-04-23 14:51     ` Atsushi Nemoto
2009-04-23 15:02       ` Alessandro Zummo
2009-04-23 15:07         ` [rtc-linux] " Mike Frysinger
     [not found]           ` <200904091627.15776.david-b@pacbell.net>
2009-04-23 15:29             ` Atsushi Nemoto
2009-04-23 15:46               ` Alessandro Zummo
2009-04-23 18:15                 ` David Brownell
2009-04-23 18:27                   ` [rtc-linux] " Alessandro Zummo
2009-04-23 19:02                     ` David Brownell
2009-04-23 19:09                       ` Alessandro Zummo
2009-04-23 19:25                         ` David Brownell
2009-04-23 19:26                           ` Alessandro Zummo
2009-04-23 19:45                             ` David Brownell
2009-04-23 19:55                               ` Alessandro Zummo
2009-04-24  9:31                                 ` David Brownell
2009-04-24 10:01                                   ` Alessandro Zummo
2009-04-24 11:10                                     ` David Brownell
2009-04-24 11:13                                       ` Alessandro Zummo
2009-04-24 16:48                                         ` Atsushi Nemoto
2009-04-24 17:06                                           ` Atsushi Nemoto
2009-04-24 19:41                                             ` Alessandro Zummo
2009-04-25 12:40                                               ` Atsushi Nemoto
2009-04-28 13:13                                             ` Hans-Christian Egtvedt
2009-04-28 15:56                                               ` Atsushi Nemoto
2009-04-23 15:37           ` Alessandro Zummo
2009-04-23 16:30             ` Mike Frysinger
2009-04-23 16:40               ` Alessandro Zummo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090423184024.39402a8f@i1501.lan.towertech.it \
    --to=alessandro.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=anemo@mba.ocn.ne.jp \
    --cc=balajirrao@openmoko.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=david-b@pacbell.net \
    --cc=hcegtvedt@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rongkai.zhan@windriver.com \
    --cc=rtc-linux@googlegroups.com \
    --cc=vapier.adi@gmail.com \
    --cc=vapier@gentoo.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.