Hi Dave, On Thu, 23 Apr 2009 00:24:03 -0700 (PDT) David Miller wrote: > > From: Stephen Rothwell > Date: Thu, 23 Apr 2009 16:38:47 +1000 > > > Today's linux-next build (powerpc allyesconfig gcc4.4.0) produced these > > warnings: > > > > drivers/net/virtio_net.c: In function 'virnet_vlan_rx_add_vid': > > include/linux/scatterlist.h:57: warning: 'sg' is used uninitialized in this function > > drivers/net/virtio_net.c:746: note: 'sg' was declared here > > drivers/net/virtio_net.c: In function 'virnet_vlan_rx_kill_vid': > > include/linux/scatterlist.h:57: warning: 'sg' is used uninitialized in this function > > drivers/net/virtio_net.c:758: note: 'sg' was declared here > > > > in each case, sg is uninitialised when its address is passed to > > sg_set_buf() which passes it to gs_set_page() which passes it to > > sg_assign_page() which dereferences it (to use ->page_link). > > I wonder if this is a side effect of changes that went in via Rusty's > tree? I don't remember touching this driver in a while. The callers came in throught commit 0bde95690d65653e420d04856c5d5783155c747c ("virtio_net: Add support for VLAN filtering in the hypervisor") which I assume came in throught the net tree (it has you SOB on it). Committed Feb 5, 2009, went into Linus' tree before 2.6.30-rc1. scatterlist.h hasn't changed since July, 2008. -- Cheers, Stephen Rothwell sfr@canb.auug.org.au http://www.canb.auug.org.au/~sfr/