From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761428AbZDXR5R (ORCPT ); Fri, 24 Apr 2009 13:57:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754025AbZDXR5B (ORCPT ); Fri, 24 Apr 2009 13:57:01 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:46156 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756130AbZDXR5A (ORCPT ); Fri, 24 Apr 2009 13:57:00 -0400 Date: Fri, 24 Apr 2009 10:51:15 -0700 From: Andrew Morton To: Mel Gorman Cc: linux-mm@kvack.org, kosaki.motohiro@jp.fujitsu.com, cl@linux-foundation.org, npiggin@suse.de, linux-kernel@vger.kernel.org, ming.m.lin@intel.com, yanmin_zhang@linux.intel.com, peterz@infradead.org, penberg@cs.helsinki.fi Subject: Re: [PATCH 09/22] Calculate the alloc_flags for allocation only once Message-Id: <20090424105115.18fec653.akpm@linux-foundation.org> In-Reply-To: <20090424104716.GE14283@csn.ul.ie> References: <1240408407-21848-1-git-send-email-mel@csn.ul.ie> <1240408407-21848-10-git-send-email-mel@csn.ul.ie> <20090423155216.07ef773e.akpm@linux-foundation.org> <20090424104716.GE14283@csn.ul.ie> X-Mailer: Sylpheed 2.4.8 (GTK+ 2.12.5; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 24 Apr 2009 11:47:17 +0100 Mel Gorman wrote: > Uninline gfp_to_alloc_flags() in the page allocator slow path Well, there are 37 inlines in page_alloc.c, so uninlining a single function (and leaving its layout mucked up ;)) is a bit random. Perhaps sometime you could take a look at "[patch] page allocator: rationalise inlining"? I'm kind of in two minds about it. Do we really know that all approved versions of gcc will do the most desirable thing in all circumstances on all architectures? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail138.messagelabs.com (mail138.messagelabs.com [216.82.249.35]) by kanga.kvack.org (Postfix) with ESMTP id 3B5A26B004D for ; Fri, 24 Apr 2009 13:56:04 -0400 (EDT) Date: Fri, 24 Apr 2009 10:51:15 -0700 From: Andrew Morton Subject: Re: [PATCH 09/22] Calculate the alloc_flags for allocation only once Message-Id: <20090424105115.18fec653.akpm@linux-foundation.org> In-Reply-To: <20090424104716.GE14283@csn.ul.ie> References: <1240408407-21848-1-git-send-email-mel@csn.ul.ie> <1240408407-21848-10-git-send-email-mel@csn.ul.ie> <20090423155216.07ef773e.akpm@linux-foundation.org> <20090424104716.GE14283@csn.ul.ie> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org To: Mel Gorman Cc: linux-mm@kvack.org, kosaki.motohiro@jp.fujitsu.com, cl@linux-foundation.org, npiggin@suse.de, linux-kernel@vger.kernel.org, ming.m.lin@intel.com, yanmin_zhang@linux.intel.com, peterz@infradead.org, penberg@cs.helsinki.fi List-ID: On Fri, 24 Apr 2009 11:47:17 +0100 Mel Gorman wrote: > Uninline gfp_to_alloc_flags() in the page allocator slow path Well, there are 37 inlines in page_alloc.c, so uninlining a single function (and leaving its layout mucked up ;)) is a bit random. Perhaps sometime you could take a look at "[patch] page allocator: rationalise inlining"? I'm kind of in two minds about it. Do we really know that all approved versions of gcc will do the most desirable thing in all circumstances on all architectures? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org