From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuji Shimada <shimada-yxb@necst.nec.co.jp>
Subject: Re: [PATCH 2/2] ioemu: don't call xc_deassign_device().
Date: Tue, 28 Apr 2009 15:02:02 +0900
Message-ID: <20090428150102.CC08.27C06F64@necst.nec.co.jp>
References: <20090424173938.B651.27C06F64@necst.nec.co.jp>
	<20090424174238.B657.27C06F64@necst.nec.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20090424174238.B657.27C06F64@necst.nec.co.jp>
List-Unsubscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

Hi Ian,

I sent two patches about the reset of devices.

The patch [1/2] has already applied to Xen.
Could you apply the patch [2/2] to ioemu?

Thanks,
--
Yuji Shimada

On Fri, 24 Apr 2009 17:43:39 +0900
Yuji Shimada <shimada-yxb@necst.nec.co.jp> wrote:

> This patch modifies ioemu not to call xc_deassign_device()
> 
> Thanks,
> --
> Yuji Shimada
> 
> 
> Signed-off-by: Yuji Shimada <shimada-yxb@necst.nec.co.jp>
> 
> diff --git a/hw/pass-through.c b/hw/pass-through.c
> index 7bd2feb..6a53137 100644
> --- a/hw/pass-through.c
> +++ b/hw/pass-through.c
> @@ -3972,13 +3972,6 @@ static int unregister_real_device(int slot)
>      /* unregister real device's MMIO/PIO BARs */
>      pt_unregister_regions(assigned_device);
>  
> -    /* deassign the dev to dom0 */
> -    bdf |= (pci_dev->bus  & 0xff) << 16;
> -    bdf |= (pci_dev->dev  & 0x1f) << 11;
> -    bdf |= (pci_dev->func & 0x1f) << 8;
> -    if ( (rc = xc_deassign_device(xc_handle, domid, bdf)) != 0)
> -        PT_LOG("Error: Revoking the device failed! rc=%d\n", rc);
> -
>      /* mark this slot as free */
>      php_dev->valid = 0;
>      php_dev->pt_dev = NULL;